Fix listWorkflows input/output handling (#294)

Author: devhawk

transact/src/main/java/dev/dbos/transact/conductor/protocol/WorkflowsOutput.java

@@ -53,7 +53,7 @@ public WorkflowsOutput(WorkflowStatus status) {
         authenticatedRoles != null && authenticatedRoles.length > 0
             ? JSONUtil.serializeArray(authenticatedRoles)
             : null;
-    this.Input = input != null ? JSONUtil.serializeArray(input) : null;
+    this.Input = input != null ? JSONUtil.toJson(input) : null;
     this.Output = output != null ? JSONUtil.toJson(output) : null;
     this.Request = null; // not used in Java TX
     this.Error =

transact/src/main/java/dev/dbos/transact/database/WorkflowDAO.java

@@ -558,7 +558,6 @@ private static WorkflowStatus resultsToWorkflowStatus(
     String serializedOutput = loadOutput ? rs.getString("output") : null;
     String serializedError = loadOutput ? rs.getString("error") : null;
     String serialization = loadInput || loadOutput ? rs.getString("serialization") : null;
-    var err = ErrorResult.deserialize(serializedError, serialization, serializer);
     WorkflowStatus info =
         new WorkflowStatus(
             workflow_uuid,
@@ -571,9 +570,14 @@ private static WorkflowStatus resultsToWorkflowStatus(
             (authenticatedRolesJson != null)
                 ? (String[]) JSONUtil.deserializeToArray(authenticatedRolesJson)
                 : null,
-            SerializationUtil.deserializePositionalArgs(serializedInput, serialization, serializer),
-            SerializationUtil.deserializeValue(serializedOutput, serialization, serializer),
-            err,
+            loadInput
+                ? SerializationUtil.deserializePositionalArgs(
+                    serializedInput, serialization, serializer)
+                : null,
+            loadOutput
+                ? SerializationUtil.deserializeValue(serializedOutput, serialization, serializer)
+                : null,
+            loadOutput ? ErrorResult.deserialize(serializedError, serialization, serializer) : null,
             rs.getString("executor_id"),
             rs.getObject("created_at", Long.class),
             rs.getObject("updated_at", Long.class),

transact/src/test/java/dev/dbos/transact/workflow/ListWorkflowsTest.java

@@ -596,10 +596,10 @@ public void testLoadInputFalse() throws Exception {
     List<WorkflowStatus> wfs = DBOS.listWorkflows(new ListWorkflowsInput().withLoadInput(false));
     assertEquals(10, wfs.size());
 
-    // inputs column is not fetched; deserializePositionalArgs(null, ...) returns [] not null
+    // inputs column is not fetched; input is null
     wfs.forEach(
         wf -> {
-          assertNotNull(wf.input());
+          assertNull(wf.input());
         });
 
     // Core metadata fields must still be populated
@@ -650,10 +650,10 @@ public void testLoadInputAndOutputBothFalse() throws Exception {
 
     assertEquals(10, wfs.size());
 
-    // Payload columns are not fetched; output/error are null, input deserializes to [] not null
+    // Payload columns are not fetched; input/output/error are null
     wfs.forEach(
         wf -> {
-          assertTrue(wf.input() == null || wf.input().length == 0);
+          assertNull(wf.input());
           assertNull(wf.output());
           assertNull(wf.error());
         });

transact/src/test/java/dev/dbos/transact/workflow/WorkflowMgmtTest.java

@@ -26,6 +26,8 @@ interface MgmtService {
   int simpleWorkflow(int input) throws InterruptedException;
 
   void stepTimingWorkflow() throws InterruptedException;
+
+  String helloWorkflow(String name);
 }
 
 class MgmtServiceImpl implements MgmtService {
@@ -60,6 +62,11 @@ public void stepTimingWorkflow() throws InterruptedException {
     DBOS.listWorkflows(new ListWorkflowsInput());
     DBOS.recv(null, Duration.ofSeconds(1));
   }
+
+  @Workflow
+  public String helloWorkflow(String name) {
+    return "Hello, %s!".formatted(name);
+  }
 }
 
 @org.junit.jupiter.api.Timeout(value = 2, unit = java.util.concurrent.TimeUnit.MINUTES)
@@ -225,4 +232,42 @@ public void queuedCancelResumeTest() throws Exception {
 
     assertEquals(WorkflowState.SUCCESS.name(), origHandle.getStatus().status());
   }
+
+  @Test
+  public void testListWorkflowsDontLoadInputOutput() throws Exception {
+    var handle = DBOS.startWorkflow(() -> proxy.helloWorkflow("Chuck"));
+    assertEquals("Hello, Chuck!", handle.getResult());
+
+    var input =
+        new ListWorkflowsInput()
+            .withWorkflowId(handle.workflowId())
+            .withLoadInput(false)
+            .withLoadOutput(false);
+    var workflows = DBOS.listWorkflows(input);
+    assertEquals(1, workflows.size());
+    var workflow = workflows.get(0);
+    assertEquals(handle.workflowId(), workflow.workflowId());
+    assertNull(workflow.input());
+    assertNull(workflow.output());
+    assertNull(workflow.error());
+    assertNull(workflow.serialization());
+  }
+
+  @Test
+  public void testListWorkflowsLoadInputOutput() throws Exception {
+    var handle = DBOS.startWorkflow(() -> proxy.helloWorkflow("Chuck"));
+    assertEquals("Hello, Chuck!", handle.getResult());
+
+    // loadInput/loadOutput default to true
+    var input = new ListWorkflowsInput().withWorkflowId(handle.workflowId());
+    var workflows = DBOS.listWorkflows(input);
+    assertEquals(1, workflows.size());
+    var workflow = workflows.get(0);
+    assertEquals(handle.workflowId(), workflow.workflowId());
+    assertEquals(1, workflow.input().length);
+    assertEquals("Chuck", workflow.input()[0]);
+    assertEquals("Hello, Chuck!", workflow.output());
+    assertNull(workflow.error());
+    assertEquals("java_jackson", workflow.serialization());
+  }
 }