Fix Flaxy Tests#396
Merged
Merged
Conversation
* fix startup recovery race condition
kraftp
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of tests were failing because of an execution window where a workflow was started before recoverPendingWorkflows on launch could run, thus attempting to recover workflows started by tests instead of previously pending. switched to using listWorkflows with a withEndTime clause prior to launch completion.
Also took the opportunity to remove sys db getPendingWorkflows since listWorkflows can handle that
Also fixed a couple of other minor test issues + a missing conductor pingTimeout cancellation