windows tests: UTF-8 manifest on OVN exes; re-baseline triage#10
Open
fw2568 wants to merge 1 commit into
Open
Conversation
Embed the UTF-8 activeCodePage manifest in every OVN executable (ovn_exe + cmake/windows-utf8.manifest) so the CRT hands argv to OVN as UTF-8 instead of re-encoding through the system ANSI code page (mirrors the OVS overlay). LF-only stdout for the OVN binaries comes from the linked OVS lib (ovs_set_program_name) once the ovs submodule carries dbosoft/ovs#52. Re-baseline on the xxreg-fixed clean ovs head, with OVN built against ovn-org#52's binary-stdout: userspace/control-plane groups 1-371 drop from 65 to 14 failures (the CRLF NB->SB convergence checks clear). known-failures.md categorizes the 14 residual (the ovn-nbctl mirror Index/Key sign-extension bug; parallelization=yes / incremental-processing tests that rely on SIGSTOP/datapath; tunnel-id exhaustion; ovn-br-controller) and records the ovn.at integration suites as a separate, larger Windows-porting effort.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to dbosoft/ovs#52 for the OVN Windows autotest suite.
Change
activeCodePagemanifest in every OVN executable (ovn_exe+cmake/windows-utf8.manifest), so the CRT deliversargv[]as UTF-8 instead of re-encoding through the system ANSI code page. Mirrors the OVS overlay.ovs_set_program_name), so it lands automatically once theovssubmodule is bumped to adbosoft-maincontaining windows tests: UTF-8 argv + LF stdout; triage suite to 2 known failures ovs#52 (binary-mode stdout).Re-baseline (userspace/control-plane, groups 1–371): 65 → 14 failures
Built against ovn-org#52's binary-stdout + the xxreg-fixed clean
ovshead. The CRLF NB→SB convergence checks (ovn-macros.at:992) now pass (122/132/170).known-failures.mdcategorizes the 14 residual:ovn-nbctlmirrorIndex/Keysign-extension (41/42/157) — a real OVN/MSVC integer bug (separate fix).parallelization=yes/ incremental-processing (100/234/256/258/259/268/290) —SIGSTOP/-CONTor datapath-bound, same family as the already-excluded incremental tests; candidates for exclusion after per-test confirmation.ovn-br-controller(353/354) — to investigate.Out of scope
The
ovn.at/ovn-controller.atintegration suites (groups 372+) are a separate, large Windows-porting effort. Note their expr/register tests show OXM/NXM name mismatches that are an OVS/OVN test-expectation version difference (real flow generation is correct), resolvable by a coordinated resync rather than a Windows fix.Depends on dbosoft/ovs#52 merged + the
ovssubmodule bumped to include it.