fix: populate model constraints regardless of contract enforcement#12710
Draft
MichelleArk wants to merge 2 commits into
Draft
fix: populate model constraints regardless of contract enforcement#12710MichelleArk wants to merge 2 commits into
MichelleArk wants to merge 2 commits into
Conversation
When contract.enforced is false, model-level constraints are now serialized to node.constraints as expected. Invalid constraint types are filtered out silently (rather than causing a mashumaro error) when the contract is not enforced. Adds functional tests covering constraints with enforced: false, no contract config, and no columns defined. Fixes #10219
Contributor
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12710 +/- ##
==========================================
- Coverage 91.38% 91.25% -0.13%
==========================================
Files 203 203
Lines 25792 25942 +150
==========================================
+ Hits 23569 23673 +104
- Misses 2223 2269 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10219
Problem
Solution
When contract.enforced is false, model-level constraints are now
serialized to node.constraints as expected. Invalid constraint types
are filtered out silently (rather than causing a mashumaro error)
when the contract is not enforced.
Adds functional tests covering constraints with enforced: false,
no contract config, and no columns defined.
Checklist