fix: escape ] in get_view_definition_sql via quotename

Address PR review feedback on get_view_definition_sql:

- Build the object name with quotename(schema) + '.' + quotename(identifier)
  instead of manual [..].[..] bracketing. quotename() doubles embedded ]
  characters, so legal identifiers containing ] no longer produce a malformed
  object name (which OBJECT_ID would resolve to NULL).
- Add a focused functional test (runs under both CI collations, CS_AS and
  CI_AS) covering an identifier that contains ] and the zero-row behavior for
  a missing view that the view materialization's diff-skip relies on.

OBJECT_ID resolution still follows database collation rules. In the view
materialization, get_view_definition_sql is only ever called on the cached
existing_relation, whose casing comes straight from the catalog, so the
lookup casing always matches the stored object even under CS_AS.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: joshmarkovic

dbt/include/sqlserver/macros/adapters/metadata.sql

@@ -92,9 +92,10 @@
 {% endmacro %}
 
 {% macro sqlserver__get_view_definition_sql(relation) -%}
+  {%- set object_name = "quotename('" ~ relation.schema ~ "') + '.' + quotename('" ~ relation.identifier ~ "')" -%}
   {{ get_use_database_sql(relation.database) }}
-  select object_definition(object_id('[{{ relation.schema }}].[{{ relation.identifier }}]', 'V')) as definition
-  where object_id('[{{ relation.schema }}].[{{ relation.identifier }}]', 'V') is not null
+  select object_definition(object_id({{ object_name }}, 'V')) as definition
+  where object_id({{ object_name }}, 'V') is not null
 {% endmacro %}
 
 {% macro sqlserver__get_relation_last_modified(information_schema, relations) -%}

tests/functional/adapter/mssql/test_get_view_definition.py

@@ -0,0 +1,57 @@
+import pytest
+
+from dbt.tests.util import run_dbt_and_capture
+
+# Builds a relation for the given schema/identifier and runs the adapter's
+# get_view_definition_sql against it, logging whether a definition row came
+# back. Lets the tests assert the macro's behaviour directly instead of going
+# through the full view materialization.
+VALIDATE_GET_VIEW_DEFINITION_MACRO = """
+{% macro validate_get_view_definition_sql(schema, identifier) -%}
+    {% set relation = api.Relation.create(
+        database=target.database, schema=schema, identifier=identifier, type='view'
+    ) %}
+    {% set result = run_query(get_view_definition_sql(relation)) %}
+    {% if result is not none and result.rows | length > 0 and result.rows[0][0] is not none %}
+        {{ log("view_definition_found: true") }}
+    {% else %}
+        {{ log("view_definition_found: false") }}
+    {% endif %}
+{% endmacro %}
+"""
+
+
+class TestGetViewDefinitionSql:
+    @pytest.fixture(scope="class")
+    def macros(self):
+        return {"validate_get_view_definition_sql.sql": VALIDATE_GET_VIEW_DEFINITION_MACRO}
+
+    def _resolve(self, schema, identifier):
+        kwargs = {"schema": schema, "identifier": identifier}
+        _, log_output = run_dbt_and_capture(
+            [
+                "--debug",
+                "run-operation",
+                "validate_get_view_definition_sql",
+                "--args",
+                str(kwargs),
+            ]
+        )
+        return log_output
+
+    def test_resolves_identifier_containing_right_bracket(self, project):
+        """A legal identifier containing ``]`` must still resolve. quotename()
+        doubles the ``]`` so OBJECT_ID gets a valid object name; the old manual
+        bracket-quoting produced a malformed name and returned NULL."""
+        identifier = "weird]name"
+        # ``]`` is escaped by doubling it inside a bracketed identifier.
+        project.run_sql(f"create view {project.test_schema}.[weird]]name] as select 1 as id")
+
+        log_output = self._resolve(project.test_schema, identifier)
+        assert "view_definition_found: true" in log_output
+
+    def test_missing_view_returns_no_rows(self, project):
+        """A view that does not exist yields zero rows, which the view
+        materialization relies on to fall through to a create."""
+        log_output = self._resolve(project.test_schema, "does_not_exist")
+        assert "view_definition_found: false" in log_output