Version 1.10.0 / 1.11.0 #659
Replies: 5 comments 7 replies
-
|
Great work on moving the adapter forward and cleaning up dependencies, really appreciated. If 1.10 is already in Critical Support (ending June 2026), We have tested dbt-sqlserver v1.9.1rc1 together with dbt 1.11.9 in a setup with 1700+ models and haven’t seen issues so far. |
Beta Was this translation helpful? Give feedback.
-
|
That's a good point on the 1.10 support ending as well, I haven't had a look at what would be required for the 1.11 support yet though, if its as simple as the 1.10 support was then we can skip right to it. |
Beta Was this translation helpful? Give feedback.
-
|
Forgot to mention this earlier: It works without changes for us, but produces deprecation warnings, mainly related to test definitions (e.g. moving to the Not sure how this behaves in 1.10, but we used --show-all-deprecations to surface them |
Beta Was this translation helpful? Give feedback.
-
|
I had the same issue, had to update all the tests in my project, that's not an adapter issue but a DBT upgrade issue that people should already be aware of it they are looking to update the adapter. |
Beta Was this translation helpful? Give feedback.
-
|
@Benjamin-Knight on final 1.9 release we should keep pyodbc as dependency, maybe a micropatch out of main, then in 1.10 we can include the two backbends on the new project format, mssql-python works very well |
Beta Was this translation helpful? Give feedback.
-
|
@axellpadilla I think the 1.9 release is pretty much done other than the update to include the pyodbc which will also land the python ecosystem update, which is invisible to most end users anyway. I'm not sure how long we want to keep it in release candidate for before releasing it fully. We will likely need a 1.10/1.11 branch so we can put all the other work we will want to do on that. Although I am wary about doing too large a release, maybe we should focus on a 1.11 upgrade release only and then start batching up 10 - 15 issues for each subsequent minor release after that? |
Beta Was this translation helpful? Give feedback.
-
|
what you think about making the v1.9 branch and release tuesday next week, for v1.10 lets keep only current milestoned changes including python deprecation (or v1.11?) and the dbt core v1.10 validations, and v1.11 after a carefull inspection of all changes from dbt core and maybe some feedback, I mean we know v1.10 works, but it should be better for consistency and to have minors for any bugfix on a specific version, we also need to upgrade a lot of dependencies for v1.11 |
Beta Was this translation helpful? Give feedback.
-
|
@Benjamin-Knight will create release/v1.9.x if you are ok with the format |
Beta Was this translation helpful? Give feedback.
-
|
I've just released version 1.9.1, we had no other reports of issues other than the resolved pyodbc dependency fix. We can either setup a 1.10 branch or just use main and do a pre-release at some point. The version 1.11 update is quite a bit more than then 1.10 branch as it means supporting UDFs which is actually proper new functionality. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks @Benjamin-Knight lets use main until release unless we need to add 1.11 features early to cleanup prs |
Beta Was this translation helpful? Give feedback.
-
|
@axellpadilla There are now pull requests against all the issues I had worked on and have flagged as being in the 1.10 release, if there any others you want to include other than your view we can tag them, or as we are getting close to 15 changes we can leave this as 1.10.0 and pick up another 10-15 for 1.10.1 |
Beta Was this translation helpful? Give feedback.
-
|
Ok, only missing thing is I want to include the mssql-python backend and officially include on testing on v1.10, should be everything, this release contains these deprecations:
|
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Thread for the version 1.10.0 release.
The actual requirements for 1.10.0 are very minimal for the adapter but this will be the first release where we start going through the issue back log. I've added a few issues to the milestone that I know I've already resolved in my 1.10.0 branch and that I've been smoke testing for a few months now.
Its available here if you want to check it out.
https://github.com/Benjamin-Knight/dbt-sqlserver/tree/support_1.10
Unfortunately as it was my own branch the commit hygiene for each issue isn't quite there for cherry picking but some of them are easily extractable.
Beta Was this translation helpful? Give feedback.
All reactions