Add regression tests for connection-string port handling (#496).#672
Merged
axellpadilla merged 1 commit intoMay 20, 2026
Conversation
Three unit tests mock pyodbc.connect and inspect the connection string built by SQLServerConnectionManager.open: port appended for windows_login, port appended for sql authentication, and port omitted when the host is a named instance (`host\instance`). Currently passes on master; serves as a tripwire if the port-handling logic regresses. No production change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This appears to have been an error in the upstream Fabric adapter, added these in as a regression test.
Closes #496