Add regression tests for limit handling in test SQL generation (#638).#675
Merged
axellpadilla merged 1 commit intoMay 20, 2026
Conversation
…sft#638). Covers sqlserver__get_test_sql's `top (...)` conditional both with and without an explicit `limit` config on a generic test. The macro currently guards correctly (`if limit != none`); these tests trip if that guard is ever removed or broken — without them, a regression that produced `select top () failures …` would only surface against models where tests actually run. No production change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers sqlserver__get_test_sql's
top (...)conditional both with and without an explicitlimitconfig on a generic test.Fixes #638