Fix reserved-keyword quoting in table-create DROP VIEW (#619).#677
Merged
axellpadilla merged 1 commit intoMay 21, 2026
Conversation
The inline EXEC('DROP VIEW IF EXISTS ...') in relations/table/create.sql
interpolated tmp_relation.schema and tmp_relation.identifier as raw
strings, so reserved-keyword schema names (e.g. `group`) emitted invalid
unquoted SQL and SQL Server raised "Incorrect syntax near the keyword
'group'". Switch to the BaseRelation renderer (include(database=False))
so the project's quoting config is respected.
Adds a functional regression test using `group` as the model schema with
quoting enabled and an autouse class-scope cleanup that drops the
[group].[model] table and [group] schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inline EXEC('DROP VIEW IF EXISTS ...') in relations/table/create.sql interpolated tmp_relation.schema and tmp_relation.identifier as raw strings.
Switch to the BaseRelation renderer (include(database=False)) so the project's quoting config is respected.
Fixes #619