Test tablock and query options interaction#679
Open
Benjamin-Knight wants to merge 4 commits into
Open
Conversation
…t#613). Supports a dict form (allowlisted hints; MAX_GRANT_PERCENT / MIN_GRANT_PERCENT use `=` syntax) and a query_options_raw escape hatch. Honoured on table, incremental (delete+insert, merge, microbatch), snapshot, and unit_test materializations; view raises a compiler error if set. apply_label() is preserved as a backward-compat alias emitting only the LABEL hint.
Enables minimal logging on bulk insert into pre-created tables when the database is in SIMPLE or BULK_LOGGED recovery. Only the contract-enforced branch of sqlserver__create_table_as is affected; the non-contract SELECT * INTO path is unchanged. Adds a functional test asserting the hint appears in compiled SQL and updates the two BaseConstraints* expected_sql fixtures to match.
…t-msft#613). A contract-enforced table model with query_options emits both `WITH (TABLOCK)` on the INSERT target and the `OPTION (...)` query hint on the SELECT side. This test only makes sense once both features are present, so it lives on a dedicated branch that merges dbt-msft#640 and dbt-msft#613.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an additional test that cover the interaction between two other pulls that add keywords to generated queries.