Avoid empty initial Plotly render - #637
Open
rosenrot00 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plotly.newPlot([], {})call from the constructorPlotly.react()initialize the plot with actual data and layoutcontentEl.datayetThe constructor currently creates a complete empty Plotly graph. The first real render then runs
Plotly.react()with the actual traces and layout, so initial card loading performs two Plotly render passes.Plotly explicitly supports
react()as an initial draw. When the target is not a plot div yet, it internally callsnewPlot()with the supplied real data. Removing the empty render therefore keeps the same initialization path while avoiding the redundant first pass.Listeners are attached only after the real plot exists and are guarded against duplicate registration and disconnected cards.