Batch history requests over WebSocket - #638
Open
rosenrot00 wants to merge 2 commits into
Open
Conversation
Owner
|
This is great work, those APIs weren't there when i first created the card. I can't test it thoroughly at the moment, but if you do and confirm everything is great I'll review from my phone and merge. Just let me know when it is ready |
Author
|
Thank you! I can confirm that all the tests created worked and that my ten plots in homeassistant work. In case someone reports an issue I will act fast, this is what I can promise :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
history/history_during_periodinstead of the REST APIThe REST path uses
hass.callApi(), which sends Home Assistant’s bearer token in the HTTPAuthorizationheader. This conflicts with reverse proxies that require HTTP Basic authentication in the same header and causes repeated authentication prompts.Using Home Assistant’s existing authenticated WebSocket avoids that header conflict. It also removes the per-request HTTP overhead and reduces a card with four compatible history entities from four requests to one.
Fixes #606