fixup! fix(dataset): Stop TimestampDataType double-shifting TIMESTAMP WITH TIME ZONE writes

Replace TimestampDataTypeIT's exception-driven skip logic with a declarative
TestFeature.TIMESTAMP_WITH_TIMEZONE flag, per CodeRabbit feedback that
catching any SQLException from the CREATE TABLE step could mask genuine
setup failures (permissions, connections, malformed DDL) as "unsupported
dialect". The zoned-column test now checks the flag up front, before
touching the database; any other SQLException during setup now propagates
as a real test failure instead of being swallowed.

Verified empirically which of the 9 profiles need the flag by running
TimestampDataTypeIT locally (scoped via -Dit.test) against each database:
* Derby, MySQL, MSSQL, DB2 reject the CREATE TABLE syntax outright
  (SQLSyntaxErrorException/equivalent) - a genuine dialect gap.
* Oracle 18/23's driver throws SQLFeatureNotSupportedException from
  getParameterMetaData() itself rather than reporting a mismatched type -
  a known ojdbc limitation, not a dialect gap, but no other driver exhibits
  it, so it shares the one flag rather than getting a dedicated one.
* H2, HSQLDB, and PostgreSQL all still need no properties change: H2/HSQLDB
  run the full assertion for real, and PostgreSQL already self-skips
  cleanly via the pre-existing plain assumeTrue(parameterType == ...) check
  (pgjdbc reports a different constant without throwing).

Refs: 831

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011fr791v2SnTRnyb1eU7LNB

Author: jeffjensen

src/test/java/org/dbunit/TestFeature.java

@@ -41,6 +41,8 @@ public class TestFeature
     public static final TestFeature SDO_GEOMETRY =
             new TestFeature("SDO_GEOMETRY");
     public static final TestFeature XML_TYPE = new TestFeature("XML_TYPE");
+    public static final TestFeature TIMESTAMP_WITH_TIMEZONE =
+            new TestFeature("TIMESTAMP_WITH_TIMEZONE");
 
     private final String _name;
 

src/test/java/org/dbunit/dataset/datatype/TimestampDataTypeIT.java

@@ -32,7 +32,9 @@
 import java.sql.Types;
 import java.time.OffsetDateTime;
 
+import org.dbunit.AbstractDatabaseIT;
 import org.dbunit.DatabaseEnvironment;
+import org.dbunit.TestFeature;
 import org.dbunit.database.IDatabaseConnection;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
@@ -45,14 +47,19 @@
  * in-memory driver used by {@link TimestampDataTypeTest}.
  *
  * <p>
- * The zoned-column test skips itself (rather than failing) when the active profile's SQL dialect
- * rejects {@code TIMESTAMP WITH TIME ZONE} column syntax, or when its JDBC driver cannot report
- * {@link Types#TIMESTAMP_WITH_TIMEZONE} from {@link java.sql.ParameterMetaData} for such a
- * column, whether by returning a different constant or by throwing {@link java.sql.SQLException}
- * (as Oracle's driver does); the fix falls back safely from both, so neither is a code defect.
- * The plain-TIMESTAMP fallback test needs no such gating since every supported database accepts
- * that syntax, though it substitutes {@code DATETIME2} on SQL Server, whose {@code TIMESTAMP} type
- * is an unrelated, non-nullable row-versioning type rather than a date/time type.
+ * The zoned-column test skips itself (rather than failing) on any profile declaring
+ * {@link TestFeature#TIMESTAMP_WITH_TIMEZONE} unsupported via
+ * {@code dbunit.profile.unsupportedFeatures} - either because the SQL dialect rejects
+ * {@code TIMESTAMP WITH TIME ZONE} column syntax outright (e.g. Derby, MySQL, SQL Server, which
+ * has no equivalent type), or because the JDBC driver cannot reliably report
+ * {@link Types#TIMESTAMP_WITH_TIMEZONE} from {@link java.sql.ParameterMetaData} for such a column
+ * even though the database itself supports the type (a known limitation of Oracle's driver, not a
+ * dbunit defect). Declaring the gap in the profile up front - rather than discovering it by
+ * catching whatever exception a given driver happens to throw - means any other failure during
+ * setup surfaces as a real test error instead of being silently treated as unsupported. The
+ * plain-TIMESTAMP fallback test needs no such gating since every supported database accepts that
+ * syntax, though it substitutes {@code DATETIME2} on SQL Server, whose {@code TIMESTAMP} type is
+ * an unrelated, non-nullable row-versioning type rather than a date/time type.
  *
  * @since 3.4.0
  */
@@ -101,33 +108,22 @@ private void dropTableQuietly(final String tableName)
     void testSetSqlValue_withOffsetDifferentFromLocalZone_writesCorrectInstantToTimestampWithTimeZoneColumn()
             throws Exception
     {
+        assumeTrue(AbstractDatabaseIT.environmentHasFeature(TestFeature.TIMESTAMP_WITH_TIMEZONE),
+                "Skipping: active database profile declares TIMESTAMP_WITH_TIMEZONE unsupported "
+                        + "(see dbunit.profile.unsupportedFeatures).");
+
         final Connection jdbcConnection = connection.getConnection();
         dropTableQuietly(ZONED_TABLE);
         try (Statement statement = jdbcConnection.createStatement())
         {
             statement.execute("CREATE TABLE " + ZONED_TABLE
                     + " (ID INTEGER NOT NULL PRIMARY KEY, TIM TIMESTAMP WITH TIME ZONE)");
-        } catch (final SQLException e)
-        {
-            assumeTrue(false,
-                    "Skipping: active database profile does not support TIMESTAMP WITH TIME ZONE columns: "
-                            + e.getMessage());
         }
 
         try (PreparedStatement insert = jdbcConnection
                 .prepareStatement("INSERT INTO " + ZONED_TABLE + " VALUES (1, ?)"))
         {
-            final int parameterType;
-            try
-            {
-                parameterType = insert.getParameterMetaData().getParameterType(1);
-            } catch (final SQLException e)
-            {
-                assumeTrue(false,
-                        "Skipping: active database driver cannot report parameter metadata for a "
-                                + "TIMESTAMP WITH TIME ZONE column: " + e.getMessage());
-                return;
-            }
+            final int parameterType = insert.getParameterMetaData().getParameterType(1);
             assumeTrue(parameterType == Types.TIMESTAMP_WITH_TIMEZONE,
                     "Skipping: active database driver does not report TIMESTAMP_WITH_TIMEZONE "
                             + "parameter metadata for this column.");

src/test/resources/db2-dbunit.properties

@@ -5,5 +5,5 @@ dbunit.profile.schema=DBUNIT
 dbunit.profile.user=dbunit
 dbunit.profile.password=dbunit
 dbunit.profile.ddl=db2xml.sql
-dbunit.profile.unsupportedFeatures=BLOB,CLOB,INSERT_IDENTITY,SDO_GEOMETRY,XML_TYPE
+dbunit.profile.unsupportedFeatures=BLOB,CLOB,INSERT_IDENTITY,SDO_GEOMETRY,XML_TYPE,TIMESTAMP_WITH_TIMEZONE
 dbunit.profile.multiLineSupport=false

src/test/resources/derby-dbunit.properties

@@ -5,5 +5,5 @@ dbunit.profile.schema=APP
 dbunit.profile.user=APP
 dbunit.profile.password=APP
 dbunit.profile.ddl=derby.sql
-dbunit.profile.unsupportedFeatures=VARBINARY,BLOB,CLOB,INSERT_IDENTITY,SDO_GEOMETRY,XML_TYPE
+dbunit.profile.unsupportedFeatures=VARBINARY,BLOB,CLOB,INSERT_IDENTITY,SDO_GEOMETRY,XML_TYPE,TIMESTAMP_WITH_TIMEZONE
 dbunit.profile.multiLineSupport=false

src/test/resources/mssql2022-dbunit.properties

@@ -5,5 +5,5 @@ dbunit.profile.schema=dbo
 dbunit.profile.user=sa
 dbunit.profile.password=theSaPassword1234
 dbunit.profile.ddl=mssql.sql
-dbunit.profile.unsupportedFeatures=BLOB,CLOB,SCROLLABLE_RESULTSET,SDO_GEOMETRY,XML_TYPE
+dbunit.profile.unsupportedFeatures=BLOB,CLOB,SCROLLABLE_RESULTSET,SDO_GEOMETRY,XML_TYPE,TIMESTAMP_WITH_TIMEZONE
 dbunit.profile.multiLineSupport=false

src/test/resources/mssql41-dbunit.properties

@@ -5,5 +5,5 @@ dbunit.profile.schema=dbo
 dbunit.profile.user=dbunit
 dbunit.profile.password=dbunit
 dbunit.profile.ddl=mssql.sql
-dbunit.profile.unsupportedFeatures=BLOB,CLOB,SCROLLABLE_RESULTSET,SDO_GEOMETRY,XML_TYPE
+dbunit.profile.unsupportedFeatures=BLOB,CLOB,SCROLLABLE_RESULTSET,SDO_GEOMETRY,XML_TYPE,TIMESTAMP_WITH_TIMEZONE
 dbunit.profile.multiLineSupport=false

src/test/resources/mysql-dbunit.properties

@@ -5,5 +5,5 @@ dbunit.profile.schema=
 dbunit.profile.user=dbunit
 dbunit.profile.password=dbunit
 dbunit.profile.ddl=mysql.sql
-dbunit.profile.unsupportedFeatures=BLOB,CLOB,SCROLLABLE_RESULTSET,INSERT_IDENTITY,SDO_GEOMETRY,XML_TYPE
+dbunit.profile.unsupportedFeatures=BLOB,CLOB,SCROLLABLE_RESULTSET,INSERT_IDENTITY,SDO_GEOMETRY,XML_TYPE,TIMESTAMP_WITH_TIMEZONE
 dbunit.profile.multiLineSupport=false

src/test/resources/oracle-free-dbunit.properties

@@ -5,5 +5,5 @@ dbunit.profile.schema=DBUNIT
 dbunit.profile.user=dbunit
 dbunit.profile.password=dbunit
 dbunit.profile.ddl=oracle.sql
-dbunit.profile.unsupportedFeatures=INSERT_IDENTITY
+dbunit.profile.unsupportedFeatures=INSERT_IDENTITY,TIMESTAMP_WITH_TIMEZONE
 dbunit.profile.multiLineSupport=false

src/test/resources/oracle-xe-dbunit.properties

@@ -5,5 +5,5 @@ dbunit.profile.schema=DBUNIT
 dbunit.profile.user=dbunit
 dbunit.profile.password=dbunit
 dbunit.profile.ddl=oracle.sql
-dbunit.profile.unsupportedFeatures=INSERT_IDENTITY
+dbunit.profile.unsupportedFeatures=INSERT_IDENTITY,TIMESTAMP_WITH_TIMEZONE
 dbunit.profile.multiLineSupport=false