Skip to content

Commit f1a6a35

Browse files
committed
fuzz: check the method call return code as well
I'm actually baffled how I managed to miss this, but thanks to sheer luck the crashes were getting detected, albeit a bit later (when dfuzzer detected the remote PID disappeared). All this surfaced once I was trying to dump a reproducer for each specific fail/crash, and was getting wrong values (i.e. values from a couple of iterations later). tl;dr we ignored when the method returned no reply or timed out.
1 parent 4930c31 commit f1a6a35

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

src/fuzz.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -482,6 +482,12 @@ int df_fuzz_test_method(
482482
ret = df_fuzz_call_method(method, value);
483483
execr = df_exec_cmd_check(execute_cmd);
484484

485+
if (ret < 0) {
486+
df_fail("%s %sFAIL%s %s - unexpected response\n",
487+
ansi_cr(), ansi_red(), ansi_normal(), method->name);
488+
break;
489+
}
490+
485491
if (execr < 0)
486492
return df_fail_ret(-1, "df_exec_cmd_check() failed: %m");
487493
else if (execr > 0) {

0 commit comments

Comments
 (0)