fix(gateway): tolerate missing SupportedVersion condition (#486)

Signed-off-by: Roel de Cort <roel.decort@adfinis.com>

Author: dc-tec

internal/controller/openbaocluster/status_gateway_test.go

@@ -114,6 +114,35 @@ func TestSetGatewayIntegrationReadyCondition_FastContract(t *testing.T) {
 			wantReason:    ReasonGatewayIntegrationReady,
 			wantMessageIn: "prerequisites are satisfied",
 		},
+		{
+			name: "gateway integration ready when class omits SupportedVersion condition",
+			cluster: func() *openbaov1alpha1.OpenBaoCluster {
+				cluster := newOpenBaoClusterStatusTestObject()
+				cluster.Spec.Gateway = &openbaov1alpha1.GatewayConfig{
+					Enabled:  true,
+					Hostname: "bao.example.test",
+					GatewayRef: openbaov1alpha1.GatewayReference{
+						Name:      "shared-gateway",
+						Namespace: "gateway-system",
+					},
+				}
+				disabled := false
+				cluster.Spec.Gateway.BackendTLS = &openbaov1alpha1.BackendTLSConfig{Enabled: &disabled}
+				return cluster
+			}(),
+			objects: []client.Object{
+				newGateway([]gatewayv1.Listener{{
+					Name:     "https",
+					Protocol: gatewayv1.HTTPSProtocolType,
+					Port:     443,
+				}}, programmedTrue),
+				newGatewayClass([]string{"HTTPRoute"}, acceptedTrue),
+			},
+			wantPresent:   true,
+			wantStatus:    metav1.ConditionTrue,
+			wantReason:    ReasonGatewayIntegrationReady,
+			wantMessageIn: "prerequisites are satisfied",
+		},
 		{
 			name: "gateway capabilities unknown when class omits features",
 			cluster: func() *openbaov1alpha1.OpenBaoCluster {

internal/service/networking/gateway_integration.go

@@ -178,7 +178,10 @@ func validateGatewayClassAccepted(gatewayClass *gatewayv1.GatewayClass) error {
 
 func validateGatewayClassSupportedVersion(gatewayClass *gatewayv1.GatewayClass) error {
 	supportedVersion := meta.FindStatusCondition(gatewayClass.Status.Conditions, string(gatewayv1.GatewayClassConditionStatusSupportedVersion))
-	if supportedVersion == nil || supportedVersion.Status == metav1.ConditionUnknown {
+	if supportedVersion == nil {
+		return nil
+	}
+	if supportedVersion.Status == metav1.ConditionUnknown {
 		return fmt.Errorf("%w: GatewayClass %q has not yet reported SupportedVersion=True", ErrGatewayClassPending, gatewayClass.Name)
 	}
 	if supportedVersion.Status == metav1.ConditionFalse {

internal/service/networking/gateway_integration_test.go

@@ -102,6 +102,31 @@ func TestValidateGatewayIntegration(t *testing.T) {
 				newGatewayClass([]gatewayv1.FeatureName{gatewayFeatureHTTPRoute, gatewayFeatureBackendTLSPolicy}, acceptedTrue, supportedVersionTrue),
 			},
 		},
+		{
+			name: "termination path tolerates class without SupportedVersion condition",
+			cluster: func() *openbaov1alpha1.OpenBaoCluster {
+				cluster := newMinimalCluster("example", "default")
+				cluster.Spec.Gateway = &openbaov1alpha1.GatewayConfig{
+					Enabled:  true,
+					Hostname: "bao.example.test",
+					GatewayRef: openbaov1alpha1.GatewayReference{
+						Name:      "shared-gateway",
+						Namespace: "gateway-system",
+					},
+				}
+				disabled := false
+				cluster.Spec.Gateway.BackendTLS = &openbaov1alpha1.BackendTLSConfig{Enabled: &disabled}
+				return cluster
+			}(),
+			objects: []client.Object{
+				newGateway([]gatewayv1.Listener{{
+					Name:     "https",
+					Protocol: gatewayv1.HTTPSProtocolType,
+					Port:     443,
+				}}, programmedTrue),
+				newGatewayClass([]gatewayv1.FeatureName{gatewayFeatureHTTPRoute}, acceptedTrue),
+			},
+		},
 		{
 			name: "listener mismatch is explicit",
 			cluster: func() *openbaov1alpha1.OpenBaoCluster {