esp32-meter-reader/http_test.go at main · dcelasun/esp32-meter-reader · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
package main

import (
	"math"
	"testing"
)

func TestCheckReadingFilter(t *testing.T) {
	tests := []struct {
		name     string
		divided  float64
		prev     float64
		incrOnly bool
		maxIncr  float64
		wantOK   bool // true = accepted (empty reason)
	}{
		// --- First reading (prev is NaN) always accepted ---
		{
			name:     "first reading accepted with incr-only",
			divided:  100,
			prev:     math.NaN(),
			incrOnly: true,
			wantOK:   true,
		},
		{
			name:    "first reading accepted with max-incr",
			divided: 100,
			prev:    math.NaN(),
			maxIncr: 10,
			wantOK:  true,
		},

		// --- incr-only tests ---
		{
			name:     "incr-only accepts equal reading",
			divided:  100,
			prev:     100,
			incrOnly: true,
			wantOK:   true,
		},
		{
			name:     "incr-only accepts higher reading",
			divided:  101,
			prev:     100,
			incrOnly: true,
			wantOK:   true,
		},
		{
			name:     "incr-only rejects lower reading",
			divided:  99,
			prev:     100,
			incrOnly: true,
			wantOK:   false,
		},

		// --- max-incr tests ---
		{
			name:    "max-incr accepts increase within limit",
			divided: 105,
			prev:    100,
			maxIncr: 10,
			wantOK:  true,
		},
		{
			name:    "max-incr accepts increase exactly at limit",
			divided: 110,
			prev:    100,
			maxIncr: 10,
			wantOK:  true,
		},
		{
			name:    "max-incr rejects increase above limit",
			divided: 111,
			prev:    100,
			maxIncr: 10,
			wantOK:  false,
		},
		{
			name:    "max-incr accepts decrease (not its job)",
			divided: 90,
			prev:    100,
			maxIncr: 10,
			wantOK:  true,
		},
		{
			name:    "max-incr accepts equal reading",
			divided: 100,
			prev:    100,
			maxIncr: 10,
			wantOK:  true,
		},

		// --- both flags combined ---
		{
			name:     "both flags: normal increase accepted",
			divided:  105,
			prev:     100,
			incrOnly: true,
			maxIncr:  10,
			wantOK:   true,
		},
		{
			name:     "both flags: decrease rejected by incr-only",
			divided:  95,
			prev:     100,
			incrOnly: true,
			maxIncr:  10,
			wantOK:   false,
		},
		{
			name:     "both flags: large increase rejected by max-incr",
			divided:  200,
			prev:     100,
			incrOnly: true,
			maxIncr:  50,
			wantOK:   false,
		},

		// --- neither flag (should never reject) ---
		{
			name:    "no flags: everything accepted",
			divided: 50,
			prev:    100,
			wantOK:  true,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			reason := checkReadingFilter(tt.divided, tt.prev, tt.incrOnly, tt.maxIncr)
			gotOK := reason == ""
			if gotOK != tt.wantOK {
				if tt.wantOK {
					t.Errorf("expected reading to be accepted, but got rejected: %s", reason)
				} else {
					t.Errorf("expected reading to be rejected, but it was accepted")
				}
			}
		})
	}
}