fix(h5): trigger onPageNotFound when navigating to unregistered routes#5967
Open
StrivingRabbit wants to merge 2 commits intouni-app-vue3-devfrom
Open
fix(h5): trigger onPageNotFound when navigating to unregistered routes#5967StrivingRabbit wants to merge 2 commits intouni-app-vue3-devfrom
StrivingRabbit wants to merge 2 commits intouni-app-vue3-devfrom
Conversation
Co-authored-by: hbcui1984 <177226+hbcui1984@users.noreply.github.com>
Size report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In H5,
onPageNotFoundwas only fired during app launch when the initial URL had no matching route. Navigating to unregistered pages vianavigateTo/redirectTo/reLaunch/switchTabsilently failed — only the APIfailcallback fired,onPageNotFoundwas never invoked.Changes
packages/uni-h5/src/service/api/route/utils.ts: After a navigation resolves without aNavigationFailure, check ifrouter.currentRoute.value.matched.length === 0. If so, invoke theonPageNotFoundapp lifecycle hook (viainvokeHook) and reject the promise.openTypeis set to the navigation type (navigateTo,redirectTo, etc.) for accurate context in the handleronPageNotFoundinvocation insetupApp()(same shape:notFound,openType,path,query,scene)Usage
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.