withCredentials is undefined in retrieveSeriesMetadata(), causing a crash

[buralog]

Bug Report: Undefined withCredentials Variable in retrieveSeriesMetadata function

Description:

I encountered an issue while using the OHIF Viewer. The application crashed with the following error:

TypeError: withCredentials is undefined
    at retrieveSeriesMetadata (api.js:XX)

Problematic Code: api.js / retrieveSeriesMetadata function

const request = getRequestOptions(options.request);
return this._httpGetApplicationJson(url, {}, false, withCredentials);

This issue appears to be caused by #103 - add request option to retrieve instances because previous version (0.10.4) works fine.
Additionally, other occurrences of withCredentials variable in the api.js might also need to be addressed.

Environment

• OHIF Viewer version: v3.9.0
• dicomweb-client version: v0.11.0
• Browser: Chrome v133

[pieper]

@LachlanNewman could you have a look at this?

[LachlanNewman]

@pieper is any unit tests defined for retrieveSeriesMetadata

[pieper]

@pieper is any unit tests defined for retrieveSeriesMetadata

It looks like no, there aren't. At this point I'll bet we could get an AI to generate some.

[arashgh68]

previous code have
let withCredentials = false; if ('withCredentials' in options) { if (options.withCredentials) { withCredentials = options.withCredentials; } }
before line 1128
return this._httpGetApplicationJson(url, {}, false, withCredentials);
and worked correctly

[deepnothing]

if ('withCredentials' in options) { if (options.withCredentials) { withCredentials = options.withCredentials; } }

adding this line as a patch did not change anything for me, still getting withCredentials is undefined

[bbearce]

Thanks so much! Was scratching my head on this and noticed it too!

I need to downgrade to 0.10.4 to get it to work. Cheers all!

[pieper]

I need to downgrade to 0.10.4 to get it to work.

Downgrading is not a good long-term solution. Can anyone propose a patch to make this work going forward?