corrected _getSharedMediaTypes to enable methods like retrieveStudy w…#56
Open
Christian-e-S wants to merge 1 commit into
Open
corrected _getSharedMediaTypes to enable methods like retrieveStudy w…#56Christian-e-S wants to merge 1 commit into
Christian-e-S wants to merge 1 commit into
Conversation
…hich check for commonMediaType === MEDIATYPES.DICOM
Contributor
|
@Christian-e-S is this still valid? I'm not familiar with the issue myself. |
|
I pass below param to retrieveStudy(options) I got an error: |
Contributor
|
Okay, this sounds reasonable, but I'm wary to change this code since it's very hard to test for any side effects. Can you create an issue and reference it here that describes the scenario in which this happens? I.e. what types of data is involved (SM? US? MR?) and what servers? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hich check for commonMediaType === MEDIATYPES.DICOM
Problem description:
Some functions like "retrieveStudy(options)" check for commonMediaType === MEDIATYPES.DICOM and throw "Media type ${commonMediaType} is not supported for retrieval of study." when the condition is not met.
Current implementation of _getSharedMediaTypes returns "application/" for "application/dicom" which will not meet the condition above.
With the modification that I have introduced, "application/dicom" will stay intact.
Please note: There was something similar in previous versions of this code.