Administration: Add IDs to the headings of the settings sections.

Add IDs to the headings of the settings sections generated by the Settings API. Additionally, adds IDs to the headings of the settings sections in the Core admin settings pages that are not generated by the Settings API.

This allows to reference specific sections by the means of links with a page fragment identifier, useful for documentation and support purposes.

Props wetah, rakeshfalke, reneyap, joedolson, afercia.
Fixes #65027.


git-svn-id: https://develop.svn.wordpress.org/trunk@62710 602fd350-edb4-49c9-b593-d223f7449a82

Author: afercia

src/wp-admin/includes/template.php

@@ -1780,7 +1780,8 @@ function do_settings_sections( $page ) {
 		}
 
 		if ( $section['title'] ) {
-			echo "<h2>{$section['title']}</h2>\n";
+			$unique_id = wp_unique_id( 'wp-settings-section-' . $section['id'] . '-' );
+			echo '<h2 id="' . esc_attr( $unique_id ) . '">' . $section['title'] . "</h2>\n";
 		}
 
 		if ( $section['callback'] ) {

src/wp-admin/network/settings.php

@@ -153,7 +153,7 @@
 	<h1><?php echo esc_html( $title ); ?></h1>
 	<form method="post" action="settings.php" novalidate="novalidate">
 		<?php wp_nonce_field( 'siteoptions' ); ?>
-		<h2><?php _e( 'Operational Settings' ); ?></h2>
+		<h2 id="wp-settings-section-operational-settings"><?php _e( 'Operational Settings' ); ?></h2>
 		<table class="form-table" role="presentation">
 			<tr>
 				<th scope="row"><label for="site_name"><?php _e( 'Network Title' ); ?></label></th>
@@ -197,7 +197,7 @@
 				</td>
 			</tr>
 		</table>
-		<h2><?php _e( 'Registration Settings' ); ?></h2>
+		<h2 id="wp-settings-section-registration-settings"><?php _e( 'Registration Settings' ); ?></h2>
 		<table class="form-table" role="presentation">
 			<?php $new_registrations_settings_title = __( 'Allow new registrations' ); ?>
 			<tr>
@@ -315,7 +315,7 @@
 			</tr>
 
 		</table>
-		<h2><?php _e( 'New Site Settings' ); ?></h2>
+		<h2 id="wp-settings-section-new-site-settings"><?php _e( 'New Site Settings' ); ?></h2>
 		<table class="form-table" role="presentation">
 
 			<tr>
@@ -396,7 +396,7 @@
 				</td>
 			</tr>
 		</table>
-		<h2><?php _e( 'Upload Settings' ); ?></h2>
+		<h2 id="wp-settings-section-upload-settings"><?php _e( 'Upload Settings' ); ?></h2>
 		<table class="form-table" role="presentation">
 			<tr>
 				<th scope="row"><?php _e( 'Site upload space' ); ?></th>
@@ -454,7 +454,7 @@
 		$translations = wp_get_available_translations();
 		if ( ! empty( $languages ) || ! empty( $translations ) ) {
 			?>
-			<h2><?php _e( 'Language Settings' ); ?></h2>
+			<h2 id="wp-settings-section-language-settings"><?php _e( 'Language Settings' ); ?></h2>
 			<table class="form-table" role="presentation">
 				<tr>
 					<th><label for="WPLANG"><?php _e( 'Default Language' ); ?><span class="dashicons dashicons-translation" aria-hidden="true"></span></label></th>
@@ -504,7 +504,7 @@
 
 		if ( $menu_items ) :
 			?>
-			<h2><?php _e( 'Menu Settings' ); ?></h2>
+			<h2 id="wp-settings-section-menu-settings"><?php _e( 'Menu Settings' ); ?></h2>
 			<table id="menu" class="form-table">
 				<?php $enable_administration_menus_title = __( 'Enable administration menus' ); ?>
 				<tr>

src/wp-admin/options-discussion.php

@@ -211,7 +211,7 @@
 <?php do_settings_fields( 'discussion', 'default' ); ?>
 </table>
 
-<h2 class="title"><?php _e( 'Avatars' ); ?></h2>
+<h2 id="wp-settings-section-avatars" class="title"><?php _e( 'Avatars' ); ?></h2>
 
 <p><?php _e( 'An avatar is an image that can be associated with a user across multiple websites. In this area, you can choose to display avatars of users who interact with the site.' ); ?></p>
 

src/wp-admin/options-media.php

@@ -52,7 +52,7 @@
 <form action="options.php" method="post">
 <?php settings_fields( 'media' ); ?>
 
-<h2 class="title"><?php _e( 'Image sizes' ); ?></h2>
+<h2 id="wp-settings-section-image-sizes" class="title"><?php _e( 'Image sizes' ); ?></h2>
 <p><?php _e( 'The sizes listed below determine the maximum dimensions in pixels to use when adding an image to the Media Library.' ); ?></p>
 
 <table class="form-table" role="presentation">
@@ -104,14 +104,14 @@
  */
 if ( isset( $GLOBALS['wp_settings']['media']['embeds'] ) ) :
 	?>
-<h2 class="title"><?php _e( 'Embeds' ); ?></h2>
+<h2 id="wp-settings-section-embeds" class="title"><?php _e( 'Embeds' ); ?></h2>
 <table class="form-table" role="presentation">
 	<?php do_settings_fields( 'media', 'embeds' ); ?>
 </table>
 <?php endif; ?>
 
 <?php if ( ! is_multisite() ) : ?>
-<h2 class="title"><?php _e( 'Uploading Files' ); ?></h2>
+<h2 id="wp-settings-section-uploading-files" class="title"><?php _e( 'Uploading Files' ); ?></h2>
 <table class="form-table" role="presentation">
 	<?php
 	/*

src/wp-admin/options-permalink.php

@@ -314,7 +314,7 @@
 /* translators: %s: Permalink structure tag. */
 $tag_already_used = __( '%s (already used in permalink structure)' );
 ?>
-<h2 class="title"><?php _e( 'Common Settings' ); ?></h2>
+<h2 id="wp-settings-section-common-settings" class="title"><?php _e( 'Common Settings' ); ?></h2>
 <p>
 <?php
 printf(
@@ -405,7 +405,7 @@ class="button button-secondary"
 </tbody>
 </table>
 
-<h2 class="title"><?php _e( 'Optional' ); ?></h2>
+<h2 id="wp-settings-section-optional" class="title"><?php _e( 'Optional' ); ?></h2>
 <p class="permalink-structure-optional-description">
 <?php
 printf(

src/wp-admin/options-writing.php

@@ -141,7 +141,7 @@
 /** This filter is documented in wp-admin/options.php */
 if ( apply_filters( 'enable_post_by_email_configuration', true ) ) {
 	?>
-<h2 class="title"><?php _e( 'Post via email' ); ?></h2>
+<h2 id="wp-settings-section-post-via-email" class="title"><?php _e( 'Post via email' ); ?></h2>
 <p>
 	<?php
 	printf(
@@ -212,7 +212,7 @@
  */
 if ( apply_filters( 'enable_update_services_configuration', true ) ) {
 	?>
-<h2 class="title"><?php _e( 'Update Services' ); ?></h2>
+<h2 id="wp-settings-section-update-services" class="title"><?php _e( 'Update Services' ); ?></h2>
 
 	<?php if ( '1' === get_option( 'blog_public' ) ) : ?>