Block visibility: add theme json opt out

Adds a setting to theme.json - `blockVisibility.allowEditing` - allowing themes to disable block visibility editing in the editor.

With `blockVisibility.allowEditing` set to `false`, the toolbar button and block options menu items in the Block Editor are hidden.

Props ramonopoly, mukesh27, isabel_brison, andrewserong.

Fixes #65592.



git-svn-id: https://develop.svn.wordpress.org/trunk@62725 602fd350-edb4-49c9-b593-d223f7449a82

Author: ramonjd

src/wp-includes/class-wp-theme-json.php

@@ -415,7 +415,7 @@ class WP_Theme_JSON {
 	 *              Added support for `dimensions.width` and `dimensions.height`.
 	 *              Added support for `typography.textIndent`.
 	 * @since 7.1.0 Added `viewport` property.
-	 *              Added support for `background.gradient`.
+	 *              Added support for `background.gradient` and `blockVisibility.allowEditing`.
 	 * @var array
 	 */
 	const VALID_SETTINGS = array(
@@ -474,6 +474,9 @@ class WP_Theme_JSON {
 			'fixed'  => null,
 			'sticky' => null,
 		),
+		'blockVisibility'               => array(
+			'allowEditing' => true,
+		),
 		'spacing'                       => array(
 			'customSpacingSize'   => null,
 			'defaultSpacingSizes' => null,
@@ -1330,7 +1333,9 @@ protected static function sanitize( $input, $valid_block_names, $valid_element_n
 		 */
 		foreach ( $valid_block_names as $block ) {
 			$schema_settings_blocks[ $block ] = static::VALID_SETTINGS;
+			// `viewport` and `blockVisibility` are global-only settings and cannot be set per block for now.
 			unset( $schema_settings_blocks[ $block ]['viewport'] );
+			unset( $schema_settings_blocks[ $block ]['blockVisibility'] );
 			$schema_styles_blocks[ $block ]             = $styles_non_top_level;
 			$schema_styles_blocks[ $block ]['elements'] = $schema_styles_elements;
 

tests/phpunit/tests/theme/wpThemeJson.php

@@ -103,6 +103,36 @@ public function test_get_settings() {
 		$this->assertEqualSetsWithIndex( $expected, $actual );
 	}
 
+	/**
+	 * @ticket 65592
+	 */
+	public function test_get_block_visibility_settings() {
+		// Test that the value passes through the full sanitization pipeline,
+		// including remove_insecure_properties (called when saving global styles).
+		$theme_json_data = array(
+			'version'  => WP_Theme_JSON::LATEST_SCHEMA,
+			'settings' => array(
+				'blockVisibility' => array(
+					'allowEditing' => false,
+				),
+				'blocks'          => array(
+					'core/group' => array(
+						'blockVisibility' => array(
+							'allowEditing' => true,
+						),
+					),
+				),
+			),
+		);
+		$sanitized       = WP_Theme_JSON::remove_insecure_properties( $theme_json_data );
+		$theme_json      = new WP_Theme_JSON( $sanitized );
+		$actual          = $theme_json->get_settings();
+
+		$this->assertFalse( $actual['blockVisibility']['allowEditing'] );
+		// The setting is global-only: block-scoped values are stripped during sanitization.
+		$this->assertArrayNotHasKey( 'blockVisibility', $actual['blocks']['core/group'] ?? array() );
+	}
+
 	/**
 	 * @ticket 53397
 	 */