Icons: Add label search support to WP_Icons_Registry.

When filtering registered icons by a search term, the registry now matches the term against each icon's `label` in addition to its `name`. Previously only the `name` was searched, so icons whose human-readable label differed from their name could not be found.

Props mcsf, wildworks.
See #64847.


git-svn-id: https://develop.svn.wordpress.org/trunk@62551 602fd350-edb4-49c9-b593-d223f7449a82

Author: t-hamano

src/wp-includes/class-wp-icons-registry.php

@@ -310,7 +310,10 @@ public function get_registered_icons( $search = '' ) {
 		$icons = array();
 
 		foreach ( $this->registered_icons as $icon ) {
-			if ( ! empty( $search ) && false === stripos( $icon['name'], $search ) ) {
+			if ( ! empty( $search )
+				&& false === stripos( $icon['name'], $search )
+				&& false === stripos( $icon['label'] ?? '', $search )
+			) {
 				continue;
 			}
 

tests/phpunit/tests/icons/wpRestIconsController.php

@@ -296,6 +296,27 @@ public function test_get_items_search_filters_results() {
 		$this->assertContains( 'core/arrow-left', $icon_names, 'Search results should include core/arrow-left icon' );
 	}
 
+	/**
+	 * Test that GET /wp/v2/icons/?search= searches icon labels too.
+	 *
+	 * @ticket 64847
+	 *
+	 * @covers ::get_items
+	 */
+	public function test_get_items_search_includes_label() {
+		wp_set_current_user( self::$editor_id );
+
+		$request = new WP_REST_Request( 'GET', '/wp/v2/icons' );
+
+		// The '@' character is only found in the *label* for core/at-symbol
+		$request->set_param( 'search', '@' );
+		$response = rest_get_server()->dispatch( $request );
+		$data     = $response->get_data();
+
+		$this->assertSame( 200, $response->get_status() );
+		$this->assertEquals( array( 'core/at-symbol' ), array_column( $data, 'name' ) );
+	}
+
 	/**
 	 * Test that search is case-insensitive.
 	 *