Privacy: Exclude the "Copied!" notice from copied policy text.

The "Copy suggested policy text to clipboard" action selected the entire accordion panel, whose contents include the actions toolbar holding the "Copied!" confirmation notice and the button label. Running `document.execCommand( 'copy' )` copies every text node in the selection, including ones hidden with CSS. So double-clicking the button, which renders the notice, leaked "Copied!" into the clipboard. Wrap the suggested policy text in a dedicated `.privacy-text-copy-content` container and select only that node, so the actions toolbar is never part of the copied range.

Developed in WordPress#12008.
Follow-up to r47572, r50161.

Props masteradhoc, vivekawsm, westonruter, sruthi89, sumitbagthariya16.
Fixes #58969.


git-svn-id: https://develop.svn.wordpress.org/trunk@62663 602fd350-edb4-49c9-b593-d223f7449a82

Author: westonruter

src/js/_enqueues/admin/privacy-tools.js

@@ -296,8 +296,10 @@ jQuery( function( $ ) {
 					range = document.createRange();
 					$parent.addClass( 'hide-privacy-policy-tutorial' );
 
-					// Copy action.
-					range.selectNodeContents( $parent[0] );
+					// Copy action. Select only the dedicated copy-content wrapper
+					// so the actions toolbar (which contains the "Copied!" notice
+					// and button label) is never part of the selection - see #58969.
+					range.selectNodeContents( $parent.find( '.privacy-text-copy-content' )[0] );
 					window.getSelection().addRange( range );
 					document.execCommand( 'copy' );
 

src/wp-admin/includes/class-wp-privacy-policy-content.php

@@ -420,10 +420,12 @@ public static function privacy_policy_guide() {
 			</button>
 			</h4>
 			<div id="privacy-settings-accordion-block-<?php echo $i; ?>" class="privacy-settings-accordion-panel privacy-text-box-body" hidden="hidden">
-				<?php
-				echo $removed;
-				echo $section['policy_text'];
-				?>
+				<div class="privacy-text-copy-content">
+					<?php
+					echo $removed;
+					echo $section['policy_text'];
+					?>
+				</div>
 				<?php if ( empty( $section['removed'] ) ) : ?>
 				<div class="privacy-settings-accordion-actions">
 					<span class="success" aria-hidden="true"><?php _e( 'Copied!' ); ?></span>