Commit 3ec114b
Fix bug where cli manifests with
Summary: Fix bug where cli manifests with `AT_DARWIN_ARM64`
ArtifactTypes fail to parse
This was an error I ran into when testing pixie-io#1997. You can see the failure
output from the [following
build](https://github.com/pixie-io/pixie/actions/runs/10705210930/job/29681122220?pr=1997)
(also copied below).
```
INFO: Running command line: bazel-bin/src/utils/artifacts/manifest_updater/manifest_updater_/manifest_updater '--manifest_updates=/__w/pixie/pixie/manifest_updates.json' '--manifest_path=/__w/pixie/pixie/gh-pages/artifacts/manifest.json'
time="2024-09-04T16:17:53Z" level=fatal msg="failed to read manifest updates" error="unknown value \"AT_DARWIN_ARM64\" for enum px.versions.ArtifactType"
```
Relevant Issues: pixie-io#1993
Type of change: /kind bugfix
Test Plan: Built the manifest_updater binary and verified it no longer
fails with a parse error
```
$ ./manifest_updater --manifest_updates manifest_updates.json --manifest_path=manifest.json
$
```
---------
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
GitOrigin-RevId: afffb8eAT_DARWIN_ARM64 ArtifactTypes fail to parse (pixie-io#2005)1 parent 59c35e8 commit 3ec114b
4 files changed
Lines changed: 46 additions & 39 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
136 | | - | |
| 136 | + | |
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
| |||
0 commit comments