revert change responsetrait and baseline

Author: ddevsr

system/API/ResponseTrait.php

@@ -26,6 +26,8 @@
  *
  * @property CLIRequest|IncomingRequest $request
  * @property ResponseInterface          $response
+ * @property bool                       $stringAsHtml Whether to treat string data as HTML in JSON response.
+ *                                                    Setting `true` is only for backward compatibility.
  */
 trait ResponseTrait
 {
@@ -82,12 +84,6 @@ trait ResponseTrait
      */
     protected $formatter;
 
-    /**
-     * Whether to treat string data as HTML in JSON response.
-     * Setting `true` is only for backward compatibility.
-     */
-    protected bool $stringAsHtml = false;
-
     /**
      * Provides a single, simple method to return an API response, formatted
      * to match the requested format, with proper content-type and status code.

utils/phpstan-baseline/loader.neon

@@ -1,4 +1,4 @@
-# total 2818 errors
+# total 2824 errors
 includes:
     - argument.type.neon
     - assign.propertyType.neon

utils/phpstan-baseline/property.notFound.neon

@@ -1,4 +1,4 @@
-# total 59 errors
+# total 65 errors
 
 parameters:
     ignoreErrors:
@@ -17,6 +17,21 @@ parameters:
             count: 14
             path: ../../system/Database/SQLSRV/Forge.php
 
+        -
+            message: '#^Access to an undefined property CodeIgniter\\Debug\\ExceptionHandler\:\:\$stringAsHtml\.$#'
+            count: 1
+            path: ../../system/Debug/ExceptionHandler.php
+
+        -
+            message: '#^Access to an undefined property CodeIgniter\\Debug\\Exceptions\:\:\$stringAsHtml\.$#'
+            count: 1
+            path: ../../system/Debug/Exceptions.php
+
+        -
+            message: '#^Access to an undefined property CodeIgniter\\RESTful\\ResourceController\:\:\$stringAsHtml\.$#'
+            count: 1
+            path: ../../system/RESTful/ResourceController.php
+
         -
             message: '#^Access to an undefined property Config\\Session\:\:\$lockAttempts\.$#'
             count: 1
@@ -27,6 +42,21 @@ parameters:
             count: 1
             path: ../../system/Session/Handlers/RedisHandler.php
 
+        -
+            message: '#^Access to an undefined property CodeIgniter\\Test\\Mock\\MockResourcePresenter\:\:\$stringAsHtml\.$#'
+            count: 1
+            path: ../../system/Test/Mock/MockResourcePresenter.php
+
+        -
+            message: '#^Access to an undefined property class@anonymous/tests/system/API/ResponseTraitTest\.php\:123\:\:\$stringAsHtml\.$#'
+            count: 1
+            path: ../../tests/system/API/ResponseTraitTest.php
+
+        -
+            message: '#^Access to an undefined property class@anonymous/tests/system/API/ResponseTraitTest\.php\:621\:\:\$stringAsHtml\.$#'
+            count: 1
+            path: ../../tests/system/API/ResponseTraitTest.php
+
         -
             message: '#^Access to an undefined property Tests\\Support\\Commands\\AppInfo\:\:\$foobar\.$#'
             count: 2