⚡ Bolt: [performance improvement] Optimize Pandas DataFrame Iteration#75
⚡ Bolt: [performance improvement] Optimize Pandas DataFrame Iteration#75alinelena wants to merge 1 commit into
Conversation
…'records') Co-authored-by: alinelena <3306823+alinelena@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced
df.iterrows()withdf.to_dict("records")when creating lookup dictionaries (parquet_by_shaandparquet_by_argone_rel) inverify_processed_omol25.py. Removed the redundant.to_dict()call onpq_rowlater in the script.🎯 Why: Iterating over a DataFrame using
df.iterrows()is notoriously slow in Pandas because it wraps every row into a PandasSeriesobject. This causes significant overhead, particularly on large DataFrames. Converting the DataFrame to a list of native Python dictionaries first allows us to bypass this abstraction overhead, drastically speeding up the dictionary comprehensions.📊 Impact: Expected to reduce execution time of the file loading and mapping generation step significantly (often an order of magnitude faster for larger datasets).
🔬 Measurement: Execute
python src/lavello_mlips/verify_processed_omol25.pyagainst a large output Parquet file and measure the time it takes to outputLoaded {len(df)} records from Parquet.vs the subsequentLoading ExtXYZ file...log.PR created automatically by Jules for task 6083572916232079911 started by @alinelena