feat: add md stability benchmark#644
Open
lwehrhan wants to merge 5 commits into
Open
Conversation
Collaborator
|
Hi @lwehrhan, from a brief look this is looking nice and i think wont need many comments from us. Could you please take a look at the element filtering mentioned by @ElliottKasoar in #429, it should be pretty straightforward to add. then we will take a deeper look over. thanks! |
ElliottKasoar
left a comment
Collaborator
There was a problem hiding this comment.
Does the benchmark save anything in terms of the trajectories? It might be interesting to see, for example, how far a simulation gets before exploding, even if it doesn't form a part of the score.
Either through that, or otherwise, it might also be nice to be able to see which systems were successfully simulated or not. Do you think this might be possible?
Co-authored-by: Elliott Kasoar <45317199+ElliottKasoar@users.noreply.github.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist for PR author
PR author must check the checkboxes below when creating the PR.
Summary
This benchmark tests if an MLIP can run stable simulations of various organic small molecules and peptides (in vacuum and in solution), as well as of a protein in vacuum.
Linked issue
Resolves #640
Progress
Testing
New decorators/callbacks