Fix dotnet doc error check and remove debugging notes#228
Open
tameware wants to merge 2 commits into
Open
Conversation
Remove a duplicate SolveBoard example that cast the return code to bool (inverted success/failure), and drop stray debugger comments from SolveAllBoards wrappers. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up the .NET wrapper documentation and code by removing an incorrect SolveBoard error-check example (that inverted success/failure) and removing debugging notes from the SolveAllBoards wrappers.
Changes:
- Removed the duplicate/incorrect
SolveBoarderror-check example indocs/dotnet_interface.md. - Removed a debugging note from the
SolveAllBoardsBinwrapper indotnet/DDS_Core/DDS.cs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| dotnet/DDS_Core/DDS.cs | Removes a stray debugging note in one SolveAllBoards overload. |
| docs/dotnet_interface.md | Removes an incorrect/duplicate SolveBoard error-check snippet from the docs example. |
tzimnoch
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SolveBoarderror-check example indocs/dotnet_interface.mdthat cast the return code tobool(inverted success/failure;NoFaultis 0).SolveAllBoardswrappers indotnet/DDS_Core/DDS.cs.Test plan
rc != (int)SolveBoardResult.NoFaultcheck remainsDDS.cshas no leftover debugging notes inSolveAllBoardsmethodsMade with Cursor