Migrate to PEP517#457
Merged
Merged
Conversation
Dropped license classifier https://peps.python.org/pep-0639/#deprecate-license-classifiers Changed the setuptools find procedure as exclude=['tests*'] included everything in the wheel. Closes: deadc0de6#409 Signed-off-by: Alfred Wingate <parona@protonmail.com>
I do not use Arch so I haven't tested these. Signed-off-by: Alfred Wingate <parona@protonmail.com>
Manually building and installing the python packages can be safely omited from the examples. Haven't tested. Signed-off-by: Alfred Wingate <parona@protonmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #457 +/- ##
==========================================
- Coverage 90.83% 90.79% -0.05%
==========================================
Files 23 23
Lines 4780 4780
==========================================
- Hits 4342 4340 -2
- Misses 438 440 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Awesome, thanks a lot for your help on this! Much appreciated! |
Contributor
Author
|
Well, got with hit suspicion that I had missed something. Broke the releases :P https://github.com/deadc0de6/dotdrop/blob/master/.github/workflows/pypi-release.yml#L25 |
Owner
|
Good catch, thanks! I hope I fixed it in 1bd00b3 but will test on next release anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropped license classifier
https://peps.python.org/pep-0639/#deprecate-license-classifiers
Changed the setuptools find procedure as exclude=['tests*'] included everything in the wheel.
Closes: #409
Todo: need to update documentation and pkgbuilds
Comparison of the sdist and wheel output with diffoscope
$ diffoscope ../dotdrop_temp/dotdrop-1.15.0.tar.gz dist/dotdrop-1.15.0.tar.gz
$ $ diffoscope --exclude-command=zipdetails ../dotdrop_temp/dotdrop-1.15.0-py3-none-any.whl dist/dotdrop-1.15.0-py3-none-any.whl
(zipdetails ignored for brevity)