Add options to minimize parsed html text#354
Draft
aleks-v-k wants to merge 2 commits into
Draft
Conversation
Contributor
|
Hello, I've recently been made a maintainer of this project. I'd be interested in these changes. I'd also be interested in a selectolax-based text extractor if you were feeling adventurous. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is to add the possibility to minimize text extracted from HTML:
The main reason for these changes: the parser is OOM killed on some large html files (there are a lot of spaces + a table).
Would you like to accept such changes? If yes, then I will add tests to cover the new code.