fix(#544): modernize xlsx handling#572
Open
KyleKing wants to merge 3 commits into
Open
Conversation
deanmalmgren
approved these changes
May 7, 2026
Owner
deanmalmgren
left a comment
deanmalmgren
left a comment
There was a problem hiding this comment.
Approving here but you'll want to be sure to add the anchors for the documentation links so the rst files render correctly
|
|
||
| * Minor nitpick to remove unused line (`#559`_ by `@KyleKing`_) | ||
| * Minor nitpick to remove unused line (`#562`_ by `@KyleKing`_) | ||
| * Utilize openpyxl for xlsx after xlrd dropped support (`#559`_ by `@KyleKing`_) |
Owner
There was a problem hiding this comment.
[dust] be sure to add links to the github issues and your username at the bottom of this file
Collaborator
Author
There was a problem hiding this comment.
Haha, I wasn't sure what this syntax was for and was just copying it. Would have eventually noticed when getting around to fixing RTD!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #544
Use openpyxl for modern xlsx, while keeping xlrd for legacy xls