Skip to content

Take decor padding into account when locating a view #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
louiskirsch wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Take decor padding into account when locating a view #170

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5de7e15
Take decor padding into account when locating a view
louiskirsch Apr 1, 2019
2d037ca
Handle context wrappers
louiskirsch Apr 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions library/src/main/java/uk/co/deanwild/materialshowcaseview/target/ViewTarget.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package uk.co.deanwild.materialshowcaseview.target;

import android.app.Activity;
import android.content.Context;
import android.content.ContextWrapper;
import android.graphics.Point;
import android.graphics.Rect;
import android.view.View;
Expand All @@ -22,11 +24,23 @@ public ViewTarget(int viewId, Activity activity) {
public Point getPoint() {
int[] location = new int[2];
mView.getLocationInWindow(location);
int x = location[0] + mView.getWidth() / 2;
int y = location[1] + mView.getHeight() / 2;
View decor = getActivity(mView).getWindow().getDecorView();
int x = location[0] - decor.getPaddingLeft() + mView.getWidth() / 2;
int y = location[1] - decor.getPaddingTop() + mView.getHeight() / 2;
return new Point(x, y);
}

private Activity getActivity(View view) {
Context context = view.getContext();
while (context instanceof ContextWrapper) {
if (context instanceof Activity) {
return (Activity)context;
}
context = ((ContextWrapper)context).getBaseContext();
}
return null;
}

@Override
public Rect getBounds() {
int[] location = new int[2];
Expand Down