Make internal buffer size configurable#20
Conversation
|
Hi, thanks for your contribution. The are some things you should check:
|
Sorry that I was so sloppy with the first patch. I fixed the typo now.
I tried to fix it according to the modbus spec. As modbus tcp needs more bytes than rtu I used it's size to be safe in both cases. However I recognized that some tests are failing now as they check that a quantity bigger than 125 fails with an error message. What is the reason for the hard coded 125 limit?
I ran Greetings, Benjamin |
98acdbb to
4b1d5a3
Compare
spell check on NMBS_INTERNAL_.........
spell check NMBS_INTERNAL_.....
I use this library in a constraint embedded environment, where I need a smaller buffer size to run it.
Would you consider accepting this change to make the buffer size configurable by the user?
Greetings Benjamin