Skip to content

Commit 2dda383

Browse files
debezium/dbz#1851 Add imagePullSecrets and extend imagePullPolicy to all chart images
Signed-off-by: Bhawani Shanker Sharma <bhawanishanker2005@gmail.com>
1 parent 1be27ac commit 2dda383

4 files changed

Lines changed: 45 additions & 2 deletions

File tree

helm/README.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,13 @@ you `values.yaml` with your domain.
6060
| schemaHistory.database.auth.username | Database username | user |
6161
| schemaHistory.database.auth.password | Database password | password | | | |
6262
| env | List of env variable to pass to the conductor | [] |
63+
| imagePullSecrets | Global list of imagePullSecrets applied to all container images. Per-component `imagePullSecrets` override this value (not merged). | [] |
64+
| stage.imagePullSecrets | Overrides global `imagePullSecrets` for the stage image. | [] |
65+
| conductor.imagePullSecrets | Overrides global `imagePullSecrets` for the conductor image. | [] |
66+
| conductor.descriptors.official.imagePullPolicy | Image pull policy for the descriptors OCI image. | IfNotPresent |
67+
| conductor.descriptors.official.imagePullSecrets | Overrides global `imagePullSecrets` for the descriptors image. | [] |
68+
| server.imagePullPolicy | Image pull policy for Debezium Server instances created by pipelines. | IfNotPresent |
69+
| server.imagePullSecrets | Overrides global `imagePullSecrets` for the Debezium Server image. | [] |
6370

6471
## Descriptor OCI Artifacts
6572

helm/templates/conductor-deployment.yaml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,13 @@ spec:
2222
app.kubernetes.io/name: conductor
2323
spec:
2424
serviceAccountName: conductor-service-account
25+
{{- $conductorSecrets := .Values.conductor.imagePullSecrets | default list }}
26+
{{- $globalSecrets := .Values.imagePullSecrets | default list }}
27+
{{- $pullSecrets := ternary $conductorSecrets $globalSecrets (gt (len $conductorSecrets) 0) }}
28+
{{- if gt (len $pullSecrets) 0 }}
29+
imagePullSecrets:
30+
{{- toYaml $pullSecrets | nindent 8 }}
31+
{{- end }}
2532
containers:
2633
- name: conductor
2734
image: {{ .Values.conductor.image }}
@@ -73,4 +80,4 @@ spec:
7380
- name: {{ .name }}
7481
value: {{ .value }}
7582
{{- end }}
76-
restartPolicy: Always
83+
restartPolicy: Always

helm/templates/stage-deployment.yaml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,13 @@ spec:
1919
labels:
2020
app.kubernetes.io/name: stage
2121
spec:
22+
{{- $stageSecrets := .Values.stage.imagePullSecrets | default list }}
23+
{{- $globalSecrets := .Values.imagePullSecrets | default list }}
24+
{{- $pullSecrets := ternary $stageSecrets $globalSecrets (gt (len $stageSecrets) 0) }}
25+
{{- if gt (len $pullSecrets) 0 }}
26+
imagePullSecrets:
27+
{{- toYaml $pullSecrets | nindent 8 }}
28+
{{- end }}
2229
containers:
2330
- image: {{ .Values.stage.image }}
2431
imagePullPolicy: {{ .Values.stage.imagePullPolicy }}
@@ -29,4 +36,4 @@ spec:
2936
env:
3037
- name: CONDUCTOR_URL
3138
value: {{ required "A valid domain URL required!" (include "debezium-platform.domainUrl" .) }}
32-
restartPolicy: Always
39+
restartPolicy: Always

helm/values.yaml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,25 @@
11
domain:
22
url: ""
33
name: ""
4+
5+
# Global imagePullSecrets applied to all container images by default.
6+
# Per-component imagePullSecrets override this value (not merged).
7+
# Example:
8+
# imagePullSecrets:
9+
# - name: my-registry-secret
10+
imagePullSecrets: []
11+
412
stage:
513
image: quay.io/debezium/platform-stage:nightly
614
imagePullPolicy: IfNotPresent
15+
# Overrides global imagePullSecrets for the stage image.
16+
imagePullSecrets: []
17+
718
conductor:
819
image: quay.io/debezium/platform-conductor:nightly
920
imagePullPolicy: IfNotPresent
21+
# Overrides global imagePullSecrets for the conductor image.
22+
imagePullSecrets: []
1023
offset:
1124
existingConfigMap: ""
1225
descriptors:
@@ -16,8 +29,17 @@ conductor:
1629
image: debezium/debezium-descriptors
1730
tag: nightly
1831
mountPath: /opt/descriptors
32+
# Image pull policy for the descriptors OCI image.
33+
imagePullPolicy: IfNotPresent
34+
# Overrides global imagePullSecrets for the descriptors image.
35+
imagePullSecrets: []
36+
1937
server:
2038
image: ""
39+
# Image pull policy for Debezium Server instances.
40+
imagePullPolicy: IfNotPresent
41+
# Overrides global imagePullSecrets for the Debezium Server image.
42+
imagePullSecrets: []
2143
ingress:
2244
enabled: true
2345
className: ""

0 commit comments

Comments
 (0)