-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix: remove attempt to get a more comprehensive error #7270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+50
−17
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
926203f
fix: remove attempt to get a more comprehensive error
martinjagodic d48e275
Merge branch 'main' into handle-duplicate-field
martinjagodic 6110971
Merge branch 'main' into handle-duplicate-field
martinjagodic 8229ed7
feat(): toast warnings for duplicate keys when loading entrties - wi…
demshy 8911cad
feat: try/catch formattedEntries
martinjagodic 547f5d7
fix: revert config
martinjagodic 8c1b789
refactor: cleanup
martinjagodic 344417b
refactor: cleanup
martinjagodic 7c9b170
refactor: format
martinjagodic e3c9782
feat: improve error messaging
martinjagodic caa41f1
fix: pass unit tests
martinjagodic 6a0fca7
refactor: format
martinjagodic 353254d
Merge branch 'main' into handle-duplicate-field
martinjagodic 53fbad9
Merge branch 'main' into handle-duplicate-field
yanthomasdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only worry is if there's a ton of errors at one time. Maybe we should aggregate it?
Also, the key is
ui.toast.duplicateFrontmatterKey, but from what I understood the code will also catch other types of parsing issues, so maybe the name should be more generic? Likeui.toast.entryParseErrors