feat: implement @dcl/rpc (#308)

* wip

* add devtools

* wip

* wip

* mocking decentraland interface

* adding events

* all scenes running with new rpc

* non functional wip

* broken wip

* fix

* fix

* remove empty generic response

* add protocol-buf in the pipelines

* also add in build step

* wip

* wip

* remove debugger

* fix: remove events when sending batch

* add stats

* add fps throttling and add initial rpcContext

* get back the devToolAdapter

* complete remaining apis

* remove old scene runtime with old rpc

* fix comms

* fix module loading

* fix getBootstrapData

* log

* test hack

* fix test

* add worker name to RpcClientPort

* remove old stuffs

* change to a right name

* add esModuleInterop option

* move 'real' to just the method name and clean code

* remove spam log

* rollout to 0 in .org

* adapt the experimental api

* implement SceneStateStorageController

* get back Stateful scenes

* fix no service

* fix builder in world

* clean code: remove didStart from EngineAPI

* fix lint

* merge from main

* PR review suggestions (#334)

* makefile suggestions

* wip

* fix avatars

* clean and kuruk review.

* typed createGenericLogComponent

* FIX ME

* lint fix

* Revert "FIX ME"

This reverts commit eedd2c1.

* Fix me 2.0

* fix lint

* bypass visible avatar test

* batched events approach

* change .ts generation to .gen.ts and clean.
fix hasManyPermissions to get permissions in a unique request

* fix circular dependency

* fix stats

* move new-rpc to runtime
clean code, remove eventChannel

* clean and pretify code

* fix tests

* filter transport closed ack error

* revert visibleAvatars logic

* fix permission loading, ethereumcontroller and parcelidentity apis

* fix build

* fix bad scenes

* remove a level of JSON.parse and JSON.stringify with protocol-buffers

* fix ethereum controller

* fix signed fetch

* fix: avoid starting more than one, and add the event when the cb fails

* optimize: send positionChanged and rotationChagned by protocol-buffer

* fix raycast

* pretify code

Co-authored-by: menduz <github@menduz.com>

Author: leanmendoza

.github/workflows/set-rollouts.yml

@@ -58,4 +58,4 @@ jobs:
           # Rollout information
           deploymentDomain: "play.decentraland.org"
           deploymentName: "@dcl/kernel"
-          percentage: 100
+          percentage: 0

.github/workflows/test-build-deploy.yml

@@ -64,8 +64,8 @@ jobs:
           cwd: ./static
 
       - name: install
-        run: npm ci
-
+        run: |
+          npm ci
       - name: build
         run: make build-essentials build-release build-deploy
       - uses: hmarr/debug-action@v2

.gitignore

@@ -94,4 +94,6 @@ public/local-ipfs
 static/package-lock.json
 **/*.dot.pdf
 **/*.dot
+
+packages/shared/apis/proto/*.ts
 lsall

Makefile

@@ -1,9 +1,18 @@
 # General setup
+PROTOBUF_VERSION = 3.20.1
+ifeq ($(shell uname),Darwin)
+PROTOBUF_ZIP = protoc-$(PROTOBUF_VERSION)-osx-x86_64.zip
+else
+PROTOBUF_ZIP = protoc-$(PROTOBUF_VERSION)-linux-x86_64.zip
+endif
 
 NODE = node
 COMPILER = $(NODE) --max-old-space-size=4096 node_modules/.bin/decentraland-compiler
 CONCURRENTLY = node_modules/.bin/concurrently
+SCENE_PROTO_FILES := $(wildcard packages/shared/apis/proto/*.proto)
+PBS_TS = $(SCENE_PROTO_FILES:packages/shared/apis/proto/%.proto=packages/shared/apis/proto/%.gen.ts)
 CWD = $(shell pwd)
+PROTOC = node_modules/.bin/protobuf/bin/protoc
 
 # Remove default Makefile rules
 
@@ -51,7 +60,7 @@ empty-parcels:
 	cp $(EMPTY_SCENES)/mappings.json static/loader/empty-scenes/mappings.json
 	cp -R $(EMPTY_SCENES)/contents static/loader/empty-scenes/contents
 
-build-essentials: $(COMPILED_SUPPORT_JS_FILES) $(SCENE_SYSTEM) $(INTERNAL_SCENES) $(DECENTRALAND_LOADER) $(GIF_PROCESSOR) $(VOICE_CHAT_CODEC_WORKER) empty-parcels
+build-essentials: ${PBS_TS} $(COMPILED_SUPPORT_JS_FILES) $(SCENE_SYSTEM) $(INTERNAL_SCENES) $(DECENTRALAND_LOADER) $(GIF_PROCESSOR) $(VOICE_CHAT_CODEC_WORKER) empty-parcels
 
 # Entry points
 static/%.js: build-essentials packages/entryPoints/%.ts
@@ -164,7 +173,6 @@ update-renderer:  ## Update the renderer
 
 madge: scripts/deps.js
 	@node scripts/deps.js
-	dot packages/scene-system/cli.scene.system.ts.dot -T pdf -O
 	dot packages/scene-system/scene.system.ts.dot -T pdf -O
 	dot packages/scene-system/stateful.scene.system.ts.dot -T pdf -O
 	dot packages/ui/decentraland-ui.scene.ts.dot -T pdf -O
@@ -181,3 +189,19 @@ madge: scripts/deps.js
 help:
 	@grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-20s\033[0m %s\n", $$1, $$2}'
 	@echo "\nYou probably want to run 'make watch' to build all the test scenes and run the local comms server."
+
+node_modules/.bin/protobuf/bin/protoc:
+	curl -OL https://github.com/protocolbuffers/protobuf/releases/download/v$(PROTOBUF_VERSION)/$(PROTOBUF_ZIP)
+	unzip -o $(PROTOBUF_ZIP) -d node_modules/.bin/protobuf
+	rm $(PROTOBUF_ZIP)
+	chmod +x node_modules/.bin/protobuf/bin/protoc
+
+packages/shared/apis/proto/%.gen.ts: packages/shared/apis/proto/%.proto node_modules/.bin/protobuf/bin/protoc
+	${PROTOC}  \
+			--plugin=./node_modules/.bin/protoc-gen-ts_proto \
+			--ts_proto_opt=esModuleInterop=true,returnObservable=false,outputServices=generic-definitions \
+			--ts_proto_opt=fileSuffix=.gen \
+			--ts_proto_out="$(PWD)/packages/shared/apis/proto" -I="$(PWD)/packages/shared/apis/proto" \
+			"$(PWD)/packages/shared/apis/proto/$*.proto";
+
+compile_apis: ${PBS_TS}