Apply suggestions from code review

Co-authored-by: Tom Greenwood <101816158+greenwoodt@users.noreply.github.com>

Author: davidbeig

install/dependencies/check_docker.sh

@@ -38,5 +38,5 @@ else
     exit 1
   fi
 
-  echo "✅ Docker is accessible for current user"
+  echo "✅ Docker is accessible for current user!"
 fi

install/dependencies/create_system_admin.sh

@@ -13,7 +13,7 @@ generate_system_admin() {
 }
 
 if [ -z "$EXTERNAL_DATABASE" ]; then
-  echo "Checking if database is already running"
+  echo "Checking if database is already running..."
   until docker ps --filter "name=decidim-db" --filter "status=running" --quiet; do
     echo "Container not running yet..."
     sleep 2

install/dependencies/decidim_version.sh

@@ -7,7 +7,7 @@ echo "💡 About Decidim versions:"
 echo "   • latest - Most recent stable release (recommended)"
 echo "   • Custom images - Your own modified Decidim builds"
 echo
-echo "If you want, later on, you can modify the 'docker-compose.yml' to change the Decidim version"
+echo "If you want, later on you can modify the 'docker-compose.yml' to change the Decidim version."
 echo
 echo "Default image: decidim/decidim:latest"
 echo
@@ -17,13 +17,13 @@ while true; do
 
   DECIDIM_IMAGE=${DECIDIM_IMAGE:-decidim/decidim:latest}
 
-  echo "Trying to pull: $DECIDIM_IMAGE"
+  echo "Attempting to pull: $DECIDIM_IMAGE"
 
   if docker pull "$DECIDIM_IMAGE"; then
     echo "✅ Successfully pulled image: $DECIDIM_IMAGE"
     break
   else
-    echo "Failed to pull image: $DECIDIM_IMAGE"
+    echo "❌ Failed to pull image: $DECIDIM_IMAGE"
     echo "Please try again."
     echo
   fi

install/dependencies/generate_gemfile.sh

@@ -3,7 +3,7 @@
 set -e
 
 echo "───────────────────────────────────────────────"
-echo "Now we are going to generate some Gemfiles so that we can track gem dependencies"
+echo "Now we are going to generate some Gemfiles, in order to track gem dependencies."
 echo
 echo "You will find everything in the Gemfile.wrapper and Gemfile.local"
 

install/dependencies/generate_vapid_keys.sh

@@ -16,7 +16,7 @@ output=$(docker run --rm \
   "$DECIDIM_IMAGE" \
   bin/rails decidim:pwa:generate_vapid_keys)
 
-echo "✅ The VAPID keys have been generated correctly"
+echo "✅ The VAPID keys have been generated correctly!"
 
 VAPID_PUBLIC_KEY=$(echo "$output" | grep 'VAPID_PUBLIC_KEY' | cut -d'=' -f2)
 VAPID_PRIVATE_KEY=$(echo "$output" | grep 'VAPID_PRIVATE_KEY' | cut -d'=' -f2)

install/dependencies/open_ports.sh

@@ -2,7 +2,7 @@
 
 open_ports() {
   echo
-  echo "To handle the SSL certificate we will have to open the port 80 and the port 443"
+  echo "To handle the SSL certificate, we will have to open the port 80 and the port 443."
   echo
 
   if ! command -v ufw; then

install/scripts/entrypoint.sh

@@ -18,7 +18,7 @@ if ! bundle check; then
   echo "❌ Gems in Gemfile are not installed. Installing them with \"bundle install\"..."
   bundle install
 else
-  echo "✅ Gems in Gemfile are installed"
+  echo "✅ Gems in Gemfile are installed!"
 fi
 
 # Check to see if there are migrations to install

install/scripts/sidekiq_entrypoint.sh

@@ -2,13 +2,13 @@
 
 # Check all the gems are installed or fails.
 if ! bundle check; then
-  echo "❌ Gems in Gemfile are not installed. Installing them with \"bundle install\"..."
+  echo "❌ Gems within the Gemfile are not installed. Installing them with \"bundle install\"..."
   if ! bundle install; then
     echo "❌ bundle install failed."
     exit 1
   fi
 else
-  echo "✅ Gems in Gemfile are installed"
+  echo "✅ Gems in Gemfile are installed!"
 fi
 
 echo "🚀" "$@"