Skip to content

Commit 11580f4

Browse files
author
Valeriy Khorunzhin
committed
fix test
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
1 parent 68dce91 commit 11580f4

1 file changed

Lines changed: 17 additions & 11 deletions

File tree

images/virtualization-artifact/pkg/controller/vmsnapshot/internal/life_cycle_test.go

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import (
2727
"k8s.io/utils/ptr"
2828
"sigs.k8s.io/controller-runtime/pkg/client"
2929

30+
"github.com/deckhouse/virtualization-controller/pkg/common/testutil"
3031
"github.com/deckhouse/virtualization-controller/pkg/controller/conditions"
3132
"github.com/deckhouse/virtualization-controller/pkg/eventrecord"
3233
virtv2 "github.com/deckhouse/virtualization/api/core/v1alpha2"
@@ -44,6 +45,7 @@ var _ = Describe("LifeCycle handler", func() {
4445
var secret *corev1.Secret
4546
var vdSnapshot *virtv2.VirtualDiskSnapshot
4647
var vmSnapshot *virtv2.VirtualMachineSnapshot
48+
var fakeClient client.WithWatch
4749

4850
BeforeEach(func() {
4951
vd = &virtv2.VirtualDisk{
@@ -142,6 +144,10 @@ var _ = Describe("LifeCycle handler", func() {
142144
},
143145
}
144146

147+
var err error
148+
fakeClient, err = testutil.NewFakeClientWithObjects(vd, vm, secret, vmSnapshot, vdSnapshot)
149+
Expect(err).ShouldNot(HaveOccurred())
150+
145151
recorder = &eventrecord.EventRecorderLoggerMock{
146152
EventFunc: func(_ client.Object, _, _, _ string) {},
147153
}
@@ -156,7 +162,7 @@ var _ = Describe("LifeCycle handler", func() {
156162
conditions.SetCondition(cb, &vm.Status.Conditions)
157163
return vm, nil
158164
}
159-
h := NewLifeCycleHandler(recorder, snapshotter, storer)
165+
h := NewLifeCycleHandler(recorder, snapshotter, storer, fakeClient)
160166

161167
_, err := h.Handle(testContext(), vmSnapshot)
162168
Expect(err).To(BeNil())
@@ -172,7 +178,7 @@ var _ = Describe("LifeCycle handler", func() {
172178
vd.Status.Phase = virtv2.DiskPending
173179
return vd, nil
174180
}
175-
h := NewLifeCycleHandler(recorder, snapshotter, storer)
181+
h := NewLifeCycleHandler(recorder, snapshotter, storer, fakeClient)
176182

177183
_, err := h.Handle(testContext(), vmSnapshot)
178184
Expect(err).To(BeNil())
@@ -191,7 +197,7 @@ var _ = Describe("LifeCycle handler", func() {
191197
conditions.SetCondition(cb, &vd.Status.Conditions)
192198
return vd, nil
193199
}
194-
h := NewLifeCycleHandler(recorder, snapshotter, storer)
200+
h := NewLifeCycleHandler(recorder, snapshotter, storer, fakeClient)
195201

196202
_, err := h.Handle(testContext(), vmSnapshot)
197203
Expect(err).To(BeNil())
@@ -211,7 +217,7 @@ var _ = Describe("LifeCycle handler", func() {
211217
conditions.SetCondition(cb, &vd.Status.Conditions)
212218
return vd, nil
213219
}
214-
h := NewLifeCycleHandler(recorder, snapshotter, storer)
220+
h := NewLifeCycleHandler(recorder, snapshotter, storer, fakeClient)
215221

216222
_, err := h.Handle(testContext(), vmSnapshot)
217223
Expect(err).To(BeNil())
@@ -230,7 +236,7 @@ var _ = Describe("LifeCycle handler", func() {
230236
return vm, nil
231237
}
232238

233-
h := NewLifeCycleHandler(recorder, snapshotter, storer)
239+
h := NewLifeCycleHandler(recorder, snapshotter, storer, fakeClient)
234240

235241
_, err := h.Handle(testContext(), vmSnapshot)
236242
Expect(err).To(BeNil())
@@ -249,7 +255,7 @@ var _ = Describe("LifeCycle handler", func() {
249255
return false
250256
}
251257

252-
h := NewLifeCycleHandler(recorder, snapshotter, storer)
258+
h := NewLifeCycleHandler(recorder, snapshotter, storer, fakeClient)
253259

254260
_, err := h.Handle(testContext(), vmSnapshot)
255261
Expect(err).To(BeNil())
@@ -271,7 +277,7 @@ var _ = Describe("LifeCycle handler", func() {
271277
return nil
272278
}
273279

274-
h := NewLifeCycleHandler(recorder, snapshotter, storer)
280+
h := NewLifeCycleHandler(recorder, snapshotter, storer, fakeClient)
275281

276282
_, err := h.Handle(testContext(), vmSnapshot)
277283
Expect(err).To(BeNil())
@@ -289,7 +295,7 @@ var _ = Describe("LifeCycle handler", func() {
289295
})
290296

291297
It("The snapshot of virtual machine is Ready", func() {
292-
h := NewLifeCycleHandler(recorder, snapshotter, storer)
298+
h := NewLifeCycleHandler(recorder, snapshotter, storer, fakeClient)
293299

294300
_, err := h.Handle(testContext(), vmSnapshot)
295301
Expect(err).To(BeNil())
@@ -303,7 +309,7 @@ var _ = Describe("LifeCycle handler", func() {
303309
})
304310

305311
It("The snapshot of running virtual machine is consistent", func() {
306-
h := NewLifeCycleHandler(recorder, snapshotter, storer)
312+
h := NewLifeCycleHandler(recorder, snapshotter, storer, fakeClient)
307313

308314
_, err := h.Handle(testContext(), vmSnapshot)
309315
Expect(err).To(BeNil())
@@ -315,7 +321,7 @@ var _ = Describe("LifeCycle handler", func() {
315321
vm.Status.Phase = virtv2.MachineStopped
316322
return vm, nil
317323
}
318-
h := NewLifeCycleHandler(recorder, snapshotter, storer)
324+
h := NewLifeCycleHandler(recorder, snapshotter, storer, fakeClient)
319325

320326
_, err := h.Handle(testContext(), vmSnapshot)
321327
Expect(err).To(BeNil())
@@ -328,7 +334,7 @@ var _ = Describe("LifeCycle handler", func() {
328334
vdSnapshot.Status.Consistent = nil
329335
return vdSnapshot, nil
330336
}
331-
h := NewLifeCycleHandler(recorder, snapshotter, storer)
337+
h := NewLifeCycleHandler(recorder, snapshotter, storer, fakeClient)
332338

333339
_, err := h.Handle(testContext(), vmSnapshot)
334340
Expect(err).To(BeNil())

0 commit comments

Comments
 (0)