Skip to content

Commit 1b5b704

Browse files
committed
require ht feature
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
1 parent de54b13 commit 1b5b704

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

images/virtualization-artifact/pkg/controller/kvbuilder/kvvm.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ func (b *KVVM) SetCPUModel(class *v1alpha2.VirtualMachineClass) error {
188188
features = append(features, virtv1.CPUFeature{Name: "svm", Policy: "optional"})
189189
}
190190
if !hasHT {
191-
features = append(features, virtv1.CPUFeature{Name: HTCPUFeature, Policy: "optional"})
191+
features = append(features, virtv1.CPUFeature{Name: HTCPUFeature, Policy: "require"})
192192
}
193193
cpu.Features = features
194194
default:

images/virtualization-artifact/pkg/controller/kvbuilder/kvvm_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ func TestSetCPUModel(t *testing.T) {
229229
name := "test-name"
230230
namespace := "test-namespace"
231231

232-
t.Run("should add optional ht feature for discovery cpu", func(t *testing.T) {
232+
t.Run("should add required ht feature for discovery cpu", func(t *testing.T) {
233233
builder := NewEmptyKVVM(types.NamespacedName{Name: name, Namespace: namespace}, KVVMOptions{})
234234
class := &v1alpha2.VirtualMachineClass{
235235
Spec: v1alpha2.VirtualMachineClassSpec{
@@ -245,8 +245,8 @@ func TestSetCPUModel(t *testing.T) {
245245
}
246246

247247
features := builder.Resource.Spec.Template.Spec.Domain.CPU.Features
248-
if !containsCPUFeature(features, virtv1.CPUFeature{Name: HTCPUFeature, Policy: "optional"}) {
249-
t.Fatalf("expected optional ht feature to be added, got %#v", features)
248+
if !containsCPUFeature(features, virtv1.CPUFeature{Name: HTCPUFeature, Policy: "require"}) {
249+
t.Fatalf("expected required ht feature to be added, got %#v", features)
250250
}
251251
})
252252

0 commit comments

Comments
 (0)