test(core): update migration scheduling lifecycle expectations

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

Author: danilrwx

images/virtualization-artifact/pkg/controller/vmop/migration/internal/handler/lifecycle_test.go

@@ -210,7 +210,7 @@ var _ = Describe("LifecycleHandler", func() {
 		),
 	)
 
-	It("should keep migration scheduling in progress after migration starts", func() {
+	It("should keep migration scheduling pending after migration starts", func() {
 		vm := newVM(v1alpha2.PreferSafeMigrationPolicy)
 		vm.Status.Conditions = []metav1.Condition{{
 			Type:   string(vmcondition.TypeMigrating),
@@ -239,10 +239,11 @@ var _ = Describe("LifecycleHandler", func() {
 		_, err := h.Handle(ctx, srv.Changed())
 		Expect(err).NotTo(HaveOccurred())
 
-		Expect(srv.Changed().Status.Phase).To(Equal(v1alpha2.VMOPPhaseInProgress))
+		Expect(srv.Changed().Status.Phase).To(Equal(v1alpha2.VMOPPhasePending))
+		Expect(srv.Changed().Status.Progress).To(Equal("2%"))
 		completed, found := conditions.GetCondition(vmopcondition.TypeCompleted, srv.Changed().Status.Conditions)
 		Expect(found).To(BeTrue())
-		Expect(completed.Reason).To(Equal(vmopcondition.ReasonMigrationPrepareTarget.String()))
+		Expect(completed.Reason).To(Equal(vmopcondition.ReasonTargetScheduling.String()))
 	})
 
 	DescribeTable("TargetMigration", func(vmPolicy v1alpha2.LiveMigrationPolicy, nodeSelector map[string]string, targetMigrationEnabled bool) {

images/virtualization-artifact/pkg/monitoring/metrics/vmop/data_metric.go

@@ -37,17 +37,17 @@ type dataMetric struct {
 }
 
 var successfulTerminalReasons = map[string]struct{}{
-	string(vmopcondition.ReasonOperationCompleted): {},
-	string(vmopcondition.ReasonMigrationCompleted): {},
+	vmopcondition.ReasonOperationCompleted.String(): {},
+	vmopcondition.ReasonMigrationCompleted.String(): {},
 }
 
 var failedTerminalReasons = map[string]struct{}{
-	string(vmopcondition.ReasonOperationFailed):     {},
-	string(vmopcondition.ReasonFailed):              {},
-	string(vmopcondition.ReasonAborted):             {},
-	string(vmopcondition.ReasonNotConverging):       {},
-	string(vmopcondition.ReasonTargetUnschedulable): {},
-	string(vmopcondition.ReasonTargetDiskError):     {},
+	vmopcondition.ReasonOperationFailed.String():     {},
+	vmopcondition.ReasonFailed.String():              {},
+	vmopcondition.ReasonAborted.String():             {},
+	vmopcondition.ReasonNotConverging.String():       {},
+	vmopcondition.ReasonTargetUnschedulable.String(): {},
+	vmopcondition.ReasonTargetDiskError.String():     {},
 }
 
 // DO NOT mutate VirtualMachineOperation!