Skip to content

Commit 44d009f

Browse files
author
Valeriy Khorunzhin
committed
e2e fix
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
1 parent ee6ee9e commit 44d009f

4 files changed

Lines changed: 20 additions & 50 deletions

File tree

test/e2e/legacy/complex.go

Lines changed: 19 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -107,23 +107,25 @@ var _ = Describe("ComplexTest", Ordered, label.Legacy(), func() {
107107
})
108108
})
109109

110-
Context("When virtual machines IP addresses are applied", func() {
111-
It("patches custom VMIP with unassigned address", func() {
112-
vmipName := fmt.Sprintf("%s-%s", namePrefix, "vm-custom-ip")
113-
Eventually(func() error {
114-
return AssignIPToVMIP(f, ns, vmipName)
115-
}).WithTimeout(LongWaitDuration).WithPolling(Interval).Should(Succeed())
116-
})
117-
118-
It("checks VMIPs phases", func() {
119-
By(fmt.Sprintf("VMIPs should be in %s phases", PhaseAttached))
120-
WaitPhaseByLabel(kc.ResourceVMIP, PhaseAttached, kc.WaitOptions{
121-
Labels: testCaseLabel,
122-
Namespace: ns,
123-
Timeout: MaxWaitTimeout,
124-
})
125-
})
126-
})
110+
// TODO: Creating a VMIP outside the allowed range is now rejected by the webhook.
111+
// Re-enable this when we figure out how to keep the test coverage.
112+
// Context("When virtual machines IP addresses are applied", func() {
113+
// It("patches custom VMIP with unassigned address", func() {
114+
// vmipName := fmt.Sprintf("%s-%s", namePrefix, "vm-custom-ip")
115+
// Eventually(func() error {
116+
// return AssignIPToVMIP(f, ns, vmipName)
117+
// }).WithTimeout(LongWaitDuration).WithPolling(Interval).Should(Succeed())
118+
// })
119+
120+
// It("checks VMIPs phases", func() {
121+
// By(fmt.Sprintf("VMIPs should be in %s phases", PhaseAttached))
122+
// WaitPhaseByLabel(kc.ResourceVMIP, PhaseAttached, kc.WaitOptions{
123+
// Labels: testCaseLabel,
124+
// Namespace: ns,
125+
// Timeout: MaxWaitTimeout,
126+
// })
127+
// })
128+
// })
127129

128130
Context("When virtual disks are applied", func() {
129131
It("checks VDs phases with consumers", func() {

test/e2e/legacy/testdata/complex-test/vm/kustomization.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ resources:
44
- overlays/default
55
- overlays/always-on
66
- overlays/embedded-cloudinit
7-
- overlays/custom-ip
7+
# - overlays/custom-ip
88
- overlays/automatic
99
- overlays/vm-a-not-b
1010
- overlays/vm-b-not-a

test/e2e/legacy/testdata/complex-test/vm/overlays/custom-ip/kustomization.yaml

Lines changed: 0 additions & 25 deletions
This file was deleted.

test/e2e/legacy/testdata/complex-test/vm/overlays/custom-ip/vmip.yaml

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)