Skip to content

Commit 4dae847

Browse files
fix(core): add missing blockdev to cdi-importer and cdi-controller (#820)
add missing blockdev to cdi-importer and cdi-controller ----------------- Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
1 parent faf9217 commit 4dae847

2 files changed

Lines changed: 26 additions & 6 deletions

File tree

images/cdi-controller/werf.inc.yaml

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,18 @@ docker:
1010
ENTRYPOINT: ["/usr/bin/cdi-controller", "-alsologtostderr"]
1111
USER: 64535
1212
---
13-
{{- $binaries := "/usr/bin/cat /usr/bin/bash /usr/bin/echo /usr/bin/cdi-controller" }}
13+
{{- define "cdi-controller-deps" -}}
14+
binaries:
15+
- /usr/bin/cat
16+
- /usr/bin/bash
17+
- /usr/bin/echo
18+
- /usr/bin/cdi-controller
19+
- /usr/sbin/blockdev
20+
packages:
21+
- tar
22+
{{- end -}}
23+
24+
{{ $cdiClonerDependencies := include "cdi-controller-deps" . | fromYaml }}
1425

1526
image: {{ $.ImageName }}-bins
1627
final: false
@@ -24,10 +35,17 @@ import:
2435
before: setup
2536
# Source https://github.com/kubevirt/containerized-data-importer/blob/v1.58.0/cmd/cdi-controller/BUILD.bazel
2637
shell:
38+
install:
39+
- |
40+
apt-get update && apt-get install --yes \
41+
{{ $cdiClonerDependencies.packages | join " " }}
42+
- |
43+
apt-get clean
44+
rm --recursive --force /var/lib/apt/lists/ftp.altlinux.org* /var/cache/apt/*.bin
2745
setup:
28-
- /relocate_binaries.sh -i "{{ $binaries }}" -o /relocate
46+
- /relocate_binaries.sh -i "{{ $cdiClonerDependencies.binaries | join " " }}" -o /relocate
2947
# tmp folder need for ready file
3048
# https://github.com/kubevirt/containerized-data-importer/blob/v1.60.3/pkg/operator/resources/namespaced/controller.go#L243
3149
- |
32-
mkdir -p /relocate/tmp
33-
chown 64535:64535 /relocate/tmp
50+
mkdir -p /relocate/{tmp,var/run/certs/cdi-uploadserver-signer,var/run/certs/cdi-uploadserver-client-signer}
51+
chown -R 64535:64535 /relocate/

images/cdi-importer/werf.inc.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,15 @@ binaries:
2727
- /usr/bin/qemu-img
2828
- /usr/bin/qemu-io
2929
- /usr/bin/qemu-nbd
30-
# All nbd bins
30+
# All nbd binaries
3131
- /usr/bin/nbd*
3232
# Mount
3333
- /usr/bin/mount /usr/bin/umount
34+
# Block device binaries
35+
- /usr/sbin/blockdev
3436
# Sqlite3
3537
- /usr/bin/sqldiff /usr/bin/sqlite3 /usr/bin/sqlite3_analyzer
36-
# CDI bind
38+
# CDI binaries
3739
- /usr/bin/cdi-containerimage-server /usr/bin/cdi-image-size-detection /usr/bin/cdi-importer /usr/bin/cdi-source-update-poller
3840
{{- end -}}
3941

0 commit comments

Comments
 (0)