fix(api): ignore not found error while deleting finalizers (#936)

Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>

Author: eofff

images/virtualization-artifact/pkg/controller/reconciler/resource.go

@@ -22,6 +22,7 @@ import (
 	"maps"
 	"reflect"
 
+	kerrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/utils/strings/slices"
@@ -205,6 +206,10 @@ func (r *Resource[T, ST]) Update(ctx context.Context) error {
 	}
 	jsonPatch := client.RawPatch(types.JSONPatchType, metadataPatchBytes)
 	if err = r.client.Patch(ctx, r.changedObj, jsonPatch); err != nil {
+		if r.changedObj.GetDeletionTimestamp() != nil && len(r.changedObj.GetFinalizers()) == 0 && kerrors.IsNotFound(err) {
+			return nil
+		}
+
 		return fmt.Errorf("error patching metadata: %w", err)
 	}
 

tests/e2e/default_config.yaml

@@ -40,8 +40,6 @@ logFilter:
   - "pattern to exclude"
   - "Server rejected event (will not retry!)" # Msg.
   - "validation failed for data source objectref" # Err.
-  - "error patching metadata: virtualdisks" # Err.
-  - "error patching metadata: virtualmachineclasses" # Err.
   - "clean up failed for data source registry" # Err.
   - "VDSnapshot object ref" # Err.
   - "VirtualDiskSnapshot " # Err.