Skip to content

Commit 5a9492a

Browse files
fix(vmop): fix panic when migration failed (#974)
fix panic when migration failed Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
1 parent 2a37e2a commit 5a9492a

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

  • images/virtualization-artifact/pkg/controller/vmop/internal/service

images/virtualization-artifact/pkg/controller/vmop/internal/service/migrate.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,11 @@ func (o MigrateOperation) IsComplete(ctx context.Context) (bool, string, error)
9696
case virtv1.MigrationSucceeded:
9797
return true, "", nil
9898
case virtv1.MigrationFailed:
99-
return true, fmt.Sprintf("Migration failed: %s", mig.Status.MigrationState.FailureReason), nil
99+
msg := "Migration failed"
100+
if mig.Status.MigrationState != nil && mig.Status.MigrationState.FailureReason != "" {
101+
msg += ": " + mig.Status.MigrationState.FailureReason
102+
}
103+
return true, msg + ".", nil
100104
default:
101105
return false, "", nil
102106
}

0 commit comments

Comments
 (0)