refactor(vm): deprecate kvvm protection finalizaer (#2488)

Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>

Author: yaroslavborbat

api/core/v1alpha2/finalizers.go

@@ -17,9 +17,12 @@ limitations under the License.
 package v1alpha2
 
 const (
-	FinalizerCVIProtection                        = "virtualization.deckhouse.io/cvi-protection"
-	FinalizerVIProtection                         = "virtualization.deckhouse.io/vi-protection"
-	FinalizerVDProtection                         = "virtualization.deckhouse.io/vd-protection"
+	FinalizerCVIProtection = "virtualization.deckhouse.io/cvi-protection"
+	FinalizerVIProtection  = "virtualization.deckhouse.io/vi-protection"
+	FinalizerVDProtection  = "virtualization.deckhouse.io/vd-protection"
+	// FinalizerKVVMProtection protects KVVMs from deletion.
+	//
+	// Deprecated: FinalizerKVVMProtection is deprecated and should be deleted in the next versions.
 	FinalizerKVVMProtection                       = "virtualization.deckhouse.io/kvvm-protection"
 	FinalizerIPAddressProtection                  = "virtualization.deckhouse.io/vmip-protection"
 	FinalizerPodProtection                        = "virtualization.deckhouse.io/pod-protection"
@@ -41,6 +44,6 @@ const (
 	FinalizerVMBDACleanup           = "virtualization.deckhouse.io/vmbda-cleanup"
 	FinalizerMACAddressCleanup      = "virtualization.deckhouse.io/vmmac-cleanup"
 	FinalizerMACAddressLeaseCleanup = "virtualization.deckhouse.io/vmmacl-cleanup"
-	FinalizerNodeUSBDeviceCleanup  = "virtualization.deckhouse.io/nodeusbdevice-cleanup"
-	FinalizerUSBDeviceCleanup      = "virtualization.deckhouse.io/usbdevice-cleanup"
+	FinalizerNodeUSBDeviceCleanup   = "virtualization.deckhouse.io/nodeusbdevice-cleanup"
+	FinalizerUSBDeviceCleanup       = "virtualization.deckhouse.io/usbdevice-cleanup"
 )

images/virtualization-artifact/pkg/controller/kvbuilder/kvvm_utils.go

@@ -144,7 +144,6 @@ func ApplyVirtualMachineSpec(
 		Version: v1alpha2.SchemeGroupVersion.Version,
 		Kind:    "VirtualMachine",
 	})
-	kvvm.AddFinalizer(v1alpha2.FinalizerKVVMProtection)
 
 	if ipAddress != "" {
 		// Set ip address cni request annotation.

images/virtualization-artifact/pkg/controller/vm/internal/deletion_handler.go

@@ -37,7 +37,7 @@ const deletionHandlerName = "DeletionHandler"
 func NewDeletionHandler(client client.Client) *DeletionHandler {
 	return &DeletionHandler{
 		client:     client,
-		protection: service.NewProtectionService(client, v1alpha2.FinalizerKVVMProtection),
+		protection: service.NewProtectionService(client, v1alpha2.FinalizerKVVMProtection), //nolint:staticcheck // FinalizerKVVMProtection is deprecated but still required until migration is complete.
 	}
 }