test: add PostCleanup precheck (#2320)

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>

Author: hardcoretime

test/e2e/README.md

@@ -90,7 +90,7 @@ task runp
 ### Debugging options
 
 - Use the FOCUS environment variable to run a specific test.
-- Set POST_CLEANUP=no to disable cleanup after tests.
+- Set POST_CLEANUP=no to disable cleanup after tests (takes precedence over isCleanupNeeded in config).
 - Set LABELS to run tests with specific label(https://onsi.github.io/ginkgo/#spec-labels).
 - Manage timeouts for new e2e tests (not for legacy tests) using env variables `E2E_SHORT_TIMEOUT`, `E2E_MIDDLE_TIMEOUT`, `E2E_LONG_TIMEOUT` and `E2E_MAX_TIMEOUT`.
 
@@ -103,6 +103,13 @@ FOCUS="ComplexTest" POST_CLEANUP=no task run
 
 POST_CLEANUP defines an environment variable used to explicitly request the deletion of created/used resources.
 
+You can also control cleanup behavior via the `isCleanupNeeded` field in `default_config.yaml`:
+```yaml
+isCleanupNeeded: true  # default: cleanup enabled
+```
+
+The POST_CLEANUP environment variable takes precedence over the YAML config.
+
 For example, run a test in no-cleanup mode:
 ```bash
 POST_CLEANUP=no task run

test/e2e/default_config.yaml

@@ -1,5 +1,7 @@
 namespaceSuffix: "e2e"
 
+isCleanupNeeded: true
+
 clusterTransport:
   kubeConfig: ""
   token: ""

test/e2e/internal/config/config.go

@@ -39,7 +39,7 @@ func GetConfig() (*Config, error) {
 	}
 	data, err := os.ReadFile(cfg)
 	if err != nil {
-		return nil, err
+		return nil, fmt.Errorf("failed to read config file %q: %w", cfg, err)
 	}
 	var conf Config
 
@@ -76,7 +76,9 @@ type Config struct {
 	LogFilter        []string         `yaml:"logFilter"`
 	CleanupResources []string         `yaml:"cleanupResources"`
 	RegexpLogFilter  []regexp.Regexp  `yaml:"regexpLogFilter"`
-	StorageClass     StorageClass
+	IsCleanupNeeded  bool             `yaml:"isCleanupNeeded"`
+
+	StorageClass StorageClass
 }
 
 type TestData struct {
@@ -130,6 +132,10 @@ type HelperImages struct {
 }
 
 func (c *Config) setEnvs() error {
+	// isCleanupNeeded: env var has priority over yaml config
+	if e, ok := os.LookupEnv("POST_CLEANUP"); ok {
+		c.IsCleanupNeeded = e != "no"
+	}
 	// ClusterTransport
 	if e, ok := os.LookupEnv("E2E_CLUSTERTRANSPORT_KUBECONFIG"); ok {
 		c.ClusterTransport.KubeConfig = e

test/e2e/internal/framework/framework.go

@@ -30,8 +30,6 @@ import (
 	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/apimachinery/pkg/util/wait"
 	"sigs.k8s.io/controller-runtime/pkg/client"
-
-	"github.com/deckhouse/virtualization/test/e2e/internal/config"
 )
 
 const (
@@ -74,7 +72,7 @@ func (f *Framework) Before() {
 func (f *Framework) After() {
 	GinkgoHelper()
 
-	if config.IsCleanUpNeeded() {
+	if GetConfig().IsCleanupNeeded {
 		defer func() {
 			if f.namespace != nil {
 				By("Cleanup: delete namespace")

test/e2e/internal/precheck/labels.go

@@ -45,6 +45,9 @@ const (
 	// PrecheckUSB - test requires USB device with dummy_hcd to be configured.
 	PrecheckUSB = "usb-precheck"
 
+	// PrecheckPostCleanup - test requires postcleanup to be configured.
+	PrecheckPostCleanup = "postcleanup-precheck"
+
 	// NoPrecheck - test doesn't require any prechecks.
 	// Use this label for tests that don't depend on cluster configuration.
 	NoPrecheck = "no-precheck"
@@ -61,6 +64,7 @@ func KnownPrecheckLabels() []string {
 		PrecheckSnapshot,
 		PrecheckVirtualization,
 		PrecheckUSB,
+		PrecheckPostCleanup,
 		NoPrecheck,
 	}
 }

test/e2e/internal/precheck/postcleanup.go

@@ -0,0 +1,62 @@
+/*
+Copyright 2026 Flant JSC
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package precheck
+
+import (
+	"context"
+	"fmt"
+	"os"
+
+	. "github.com/onsi/ginkgo/v2"
+
+	"github.com/deckhouse/virtualization/test/e2e/internal/framework"
+)
+
+const (
+	postCleanupPrecheckEnvName = "POST_CLEANUP"
+)
+
+// postcleanupPrecheck implements Precheck interface for postcleanup option.
+// This is a common precheck that runs for all tests.
+type postcleanupPrecheck struct{}
+
+func (c *postcleanupPrecheck) Label() string {
+	return PrecheckPostCleanup
+}
+
+func (c *postcleanupPrecheck) Run(ctx context.Context, f *framework.Framework) error {
+	if !isCheckEnabled(postCleanupPrecheckEnvName) {
+		_, _ = GinkgoWriter.Write([]byte("PostCleanup precheck is disabled.\n"))
+		return nil
+	}
+
+	// Validate POST_CLEANUP env var
+	env := os.Getenv(postCleanupPrecheckEnvName)
+	switch env {
+	case "yes", "no", "":
+		// valid values
+	default:
+		return fmt.Errorf("invalid value for the %s env: %q (allowed: \"\", \"yes\", \"no\")", postCleanupPrecheckEnvName, env)
+	}
+
+	return nil
+}
+
+// Register postcleanup precheck as common (runs for all tests).
+func init() {
+	RegisterPrecheck(&postcleanupPrecheck{}, true)
+}

test/e2e/legacy/complex.go

@@ -54,7 +54,7 @@ var _ = Describe("ComplexTest", Ordered, label.Legacy(), Label(precheck.NoPreche
 	})
 
 	AfterAll(func() {
-		if config.IsCleanUpNeeded() {
+		if conf.IsCleanupNeeded {
 			DeleteTestCaseResources(ns, ResourcesToDelete{
 				KustomizationDir: conf.TestData.ComplexTest,
 			})

test/e2e/legacy/image_hotplug.go

@@ -78,7 +78,7 @@ var _ = Describe("ImageHotplug", Ordered, label.Legacy(), Label(precheck.NoPrech
 	})
 
 	AfterAll(func() {
-		if config.IsCleanUpNeeded() {
+		if conf.IsCleanupNeeded {
 			DeleteTestCaseResources(ns, ResourcesToDelete{
 				KustomizationDir: conf.TestData.ImageHotplug,
 			})

test/e2e/legacy/legacy.go

@@ -157,7 +157,7 @@ func NewBeforeProcess1Body() {
 }
 
 func NewAfterAllProcessBody() {
-	if config.IsCleanUpNeeded() {
+	if conf.IsCleanupNeeded {
 		Expect(Cleanup()).To(Succeed())
 	}
 }

test/e2e/legacy/vd_snapshots.go

@@ -79,7 +79,7 @@ var _ = Describe("VirtualDiskSnapshots", Ordered, label.Legacy(), Label(precheck
 	})
 
 	AfterAll(func() {
-		if config.IsCleanUpNeeded() {
+		if conf.IsCleanupNeeded {
 			DeleteTestCaseResources(ns, ResourcesToDelete{
 				KustomizationDir: conf.TestData.VdSnapshots,
 			})