chore(ci): e2e report improve (#2355)

Description
Improve the E2E messenger report generated by CI and reorganize the
report scripts so the same logic is easier to follow.

User-facing changes:

Add a Reason column to the failed-tests thread table and rename
Test group to Tests.
Link cluster names in failed-tests thread replies to the matching
workflow/job URL.
Hide the Errors column in the main test-results table when there
are no Ginkgo errors.
Calculate Success Rate from executed specs only:
passed / (passed + failed + errors).
Add table header emojis to the main report.
Use the full Ginkgo Failure.Message text as the failed-test reason.
Stop wrapping *exec.ExitError with %w in
test/e2e/internal/framework/ssh.go so Ginkgo no longer dumps Go
internals into the report when an SSH command fails.
Capture Ginkgo stdout/stderr in the reusable pipeline and parse it as
a fallback report source so suite-level failures such as
SynchronizedBeforeSuite are still surfaced when the JSON report is
missing or contains only setup failure data.
Internal refactors (no behavior change, covered by existing tests):

Move the shared withTempDir / createCore jest helpers into
shared/test-utils.js to remove duplication across three test files.
Extract escapeRegExp in shared/report-model.js; consolidate
buildStatusMessage into a status → template lookup table; remove a
redundant ternary in buildClusterStatus.
Unify the Ginkgo source lookup (findGinkgoReport /
findGinkgoOutput → one findGinkgoSource) and call
parseGinkgoFile once with the descriptor picked up front.
Iterate over a list of required keys in
requireClusterReportConfig instead of three identical if blocks.
Pre-filter cluster reports once by storage key and merge
renderClusterFailuresSection / renderMissingReportsSection into
a single renderBulletSection helper. Output stays byte-identical;
verified by existing messenger-report tests.
Pass the loop credentials object as-is to postToLoopApi so the
two call sites collapse to one-liners.

---------

Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>

Author: universal-itengineer

.github/scripts/js/e2e/report/cluster-report.js

@@ -13,12 +13,16 @@
 const fs = require("fs");
 
 const { findSingleMatchingFile } = require("./shared/fs-utils");
-const { parseGinkgoReport } = require("./shared/ginkgo-report-utils");
+const {
+  parseGinkgoOutput,
+  parseGinkgoReport,
+} = require("./shared/ginkgo-report-utils");
 const {
   archivedReportPattern,
   buildClusterStatus,
   buildReportSummary,
   buildTestStatus,
+  ginkgoOutputPattern,
   reportFileName,
   zeroMetrics,
 } = require("./shared/report-model");
@@ -83,17 +87,13 @@ function readClusterReportConfigFromEnv(env = process.env) {
   };
 }
 
-function requireClusterReportConfig(config) {
-  if (!config.storageType) {
-    throw new Error("buildClusterReport requires storageType");
-  }
+const requiredClusterReportConfigKeys = ["storageType", "reportsDir", "reportFile"];
 
-  if (!config.reportsDir) {
-    throw new Error("buildClusterReport requires reportsDir");
-  }
-
-  if (!config.reportFile) {
-    throw new Error("buildClusterReport requires reportFile");
+function requireClusterReportConfig(config) {
+  for (const key of requiredClusterReportConfigKeys) {
+    if (!config[key]) {
+      throw new Error(`buildClusterReport requires ${key}`);
+    }
   }
 
   return { ...config };
@@ -168,42 +168,110 @@ async function readStageJobUrlsFromApi(github, context, config, core) {
   return stageJobUrls;
 }
 
-function findGinkgoReport(config) {
-  const rawReportPattern = archivedReportPattern(config.storageType);
+/**
+ * Builds a parsed-report payload used as a placeholder when no source data
+ * is available, so the downstream report builder can keep working with a
+ * uniform shape.
+ *
+ * @param {string} source Source label to record on the placeholder.
+ * @returns {{
+ *   metrics: ReturnType<typeof zeroMetrics>,
+ *   failedTests: string[],
+ *   failedTestDetails: Array<{name: string, reason: string}>,
+ *   startedAt: null,
+ *   source: string,
+ * }} Empty parsed-report payload.
+ */
+function emptyParsedReport(source) {
+  return {
+    metrics: zeroMetrics(),
+    failedTests: [],
+    failedTestDetails: [],
+    startedAt: null,
+    source,
+  };
+}
+
+const ginkgoJsonSource = {
+  label: "Ginkgo JSON report",
+  okSource: "ginkgo-json",
+  invalidSource: "ginkgo-json-invalid",
+  parse: parseGinkgoReport,
+  pattern: archivedReportPattern,
+};
+
+const ginkgoOutputSource = {
+  label: "Ginkgo output log",
+  okSource: "ginkgo-output",
+  invalidSource: "ginkgo-output-invalid",
+  parse: parseGinkgoOutput,
+  pattern: ginkgoOutputPattern,
+};
 
+/**
+ * @typedef {Object} GinkgoSourceDescriptor
+ * @property {string} label Human-readable source name for log lines and warnings.
+ * @property {string} okSource Source tag stored on a successful parse result.
+ * @property {string} invalidSource Source tag stored when parsing fails.
+ * @property {function(string): {
+ *   metrics: ReturnType<typeof zeroMetrics>,
+ *   failedTests: string[],
+ *   failedTestDetails: Array<{name: string, reason: string}>,
+ *   startedAt: string|null,
+ * }} parse Parser function for the source content.
+ * @property {function(string): RegExp} pattern Builds the file-name regex for the source.
+ */
+
+/**
+ * Locates a single Ginkgo source file (JSON report or stdout fallback log)
+ * for the configured storage type. Throws when more than one matching file
+ * exists; returns null when none is found.
+ *
+ * @param {ClusterReportConfig} config Resolved cluster report config.
+ * @param {GinkgoSourceDescriptor} source Source descriptor.
+ * @returns {string|null} Path to the source file, or null when none exists.
+ */
+function findGinkgoSource(config, source) {
   return findSingleMatchingFile(
     config.reportsDir,
-    rawReportPattern,
-    "Ginkgo JSON report"
+    source.pattern(config.storageType),
+    source.label
   );
 }
 
-function parseGinkgoReportFile(rawReportPath, core) {
-  if (!rawReportPath) {
-    return {
-      metrics: zeroMetrics(),
-      failedTests: [],
-      startedAt: null,
-      source: "empty",
-    };
+/**
+ * Reads and parses a Ginkgo source file (JSON report or stdout log) using
+ * the provided source descriptor. Returns an empty placeholder when the
+ * file path is missing or the parser throws, so the caller always receives
+ * a consistent parsed-report shape.
+ *
+ * @param {string|null} filePath Path to the source file, or null/empty.
+ * @param {ClusterReportCore} core GitHub Actions core API.
+ * @param {GinkgoSourceDescriptor} source Source descriptor.
+ * @returns {{
+ *   metrics: ReturnType<typeof zeroMetrics>,
+ *   failedTests: string[],
+ *   failedTestDetails: Array<{name: string, reason: string}>,
+ *   startedAt: string|null,
+ *   source: string,
+ * }} Parsed report payload with a source tag.
+ */
+function parseGinkgoFile(filePath, core, source) {
+  if (!filePath) {
+    return emptyParsedReport("empty");
   }
 
-  core.info(`Found Ginkgo JSON report: ${rawReportPath}`);
+  core.info(`Found ${source.label}: ${filePath}`);
   try {
     return {
-      ...parseGinkgoReport(fs.readFileSync(rawReportPath, "utf8")),
-      source: "ginkgo-json",
+      ...source.parse(fs.readFileSync(filePath, "utf8")),
+      source: source.okSource,
     };
   } catch (error) {
     core.warning(
-      `Unable to parse Ginkgo JSON report ${rawReportPath}: ${error.message}`
+      `Unable to parse ${source.label} ${filePath}: ${error.message}`
     );
-    return {
-      metrics: zeroMetrics(),
-      failedTests: [],
-      startedAt: null,
-      source: "ginkgo-json-invalid",
-    };
+    return emptyParsedReport(source.invalidSource);
   }
 }
 
@@ -213,7 +281,7 @@ function buildReportPayload({
   fallbackWorkflowRunUrl,
   branchName,
   parsedReport,
-  rawReportPath,
+  sourcePath,
 }) {
   const clusterStatus = buildClusterStatus(config.stageResults);
   const testStatus = buildTestStatus(
@@ -251,7 +319,8 @@ function buildReportPayload({
     startedAt: parsedReport.startedAt,
     metrics: parsedReport.metrics,
     failedTests: parsedReport.failedTests,
-    sourceReport: rawReportPath,
+    failedTestDetails: parsedReport.failedTestDetails,
+    sourceReport: sourcePath,
     reportSource: parsedReport.source,
   };
 }
@@ -317,22 +386,27 @@ async function buildClusterReport({ core, context, github, config } = {}) {
 
   const fallbackWorkflowRunUrl = getWorkflowRunUrl(context);
   const branchName = getBranchName(context);
-  const rawReportPath = findGinkgoReport(resolvedConfig);
+  const rawReportPath = findGinkgoSource(resolvedConfig, ginkgoJsonSource);
+  const outputPath = rawReportPath
+    ? null
+    : findGinkgoSource(resolvedConfig, ginkgoOutputSource);
+  const sourcePath = rawReportPath || outputPath;
+  const sourceDescriptor = rawReportPath ? ginkgoJsonSource : ginkgoOutputSource;
 
   if (!rawReportPath) {
     core.warning(
       `Ginkgo JSON report was not found for ${resolvedConfig.storageType} under ${resolvedConfig.reportsDir}`
     );
   }
 
-  const parsedReport = parseGinkgoReportFile(rawReportPath, core);
+  const parsedReport = parseGinkgoFile(sourcePath, core, sourceDescriptor);
   const report = buildReportPayload({
     config: resolvedConfig,
     context,
     fallbackWorkflowRunUrl,
     branchName,
     parsedReport,
-    rawReportPath,
+    sourcePath,
   });
 
   try {