fix(vm): correct CPU core validation logic for range checks (#824)

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

Author: danilrwx

images/virtualization-artifact/pkg/controller/vm/internal/validators/cpu_count_validator.go

@@ -45,11 +45,11 @@ func (v *CpuCountValidator) Validate(vm *v1alpha2.VirtualMachine) (admission.War
 	switch {
 	case cores <= 16:
 		return nil, nil
-	case cores <= 32 && cores%2 != 0:
+	case cores > 16 && cores <= 32 && cores%2 != 0:
 		return nil, fmt.Errorf("the requested number of cores must be a multiple of 2")
-	case cores <= 64 && cores%4 != 0:
+	case cores > 32 && cores <= 64 && cores%4 != 0:
 		return nil, fmt.Errorf("the requested number of cores must be a multiple of 4")
-	case cores%8 != 0:
+	case cores > 64 && cores%8 != 0:
 		return nil, fmt.Errorf("the requested number of cores must be a multiple of 8")
 	}
 

images/virtualization-artifact/pkg/controller/vm/internal/validators/cpu_count_validator_test.go

@@ -0,0 +1,75 @@
+/*
+Copyright 2024 Flant JSC
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package validators
+
+import (
+	"testing"
+
+	"github.com/deckhouse/virtualization/api/core/v1alpha2"
+)
+
+func TestCpuCountValidate(t *testing.T) {
+	tests := []struct {
+		desiredCores int
+		valid        bool
+	}{
+		{1, true},
+		{2, true},
+		{3, true},
+		{4, true},
+		{5, true},
+		{15, true},
+		{16, true},
+
+		{18, true},
+		{19, false},
+		{20, true},
+		{31, false},
+		{32, true},
+
+		{36, true},
+		{37, false},
+		{40, true},
+		{60, true},
+		{63, false},
+		{64, true},
+
+		{72, true},
+		{76, false},
+		{80, true},
+		{248, true},
+		{256, true},
+		{252, false},
+	}
+
+	for _, test := range tests {
+		t.Run("", func(t *testing.T) {
+			vm := &v1alpha2.VirtualMachine{Spec: v1alpha2.VirtualMachineSpec{CPU: v1alpha2.CPUSpec{Cores: test.desiredCores}}}
+			cpuCountValidator := NewCpuCountValidator()
+
+			_, err := cpuCountValidator.Validate(vm)
+
+			if test.valid && err != nil {
+				t.Errorf("For %d cores, expected valid, but validation failed", test.desiredCores)
+			}
+
+			if !test.valid && err == nil {
+				t.Errorf("For %d cores, expected not valid, but validation succeeded", test.desiredCores)
+			}
+		})
+	}
+}