fix(vmop): prevent Maintenance mode from getting stuck during restore (#2144)

* fix(vmop): prevent Maintenance mode from getting stuck during restore

Return reconcile.Result instead of nil to properly complete the reconciliation
loop when snapshot steps exit early (exit maintenance step, waiting disk ready step).

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

* fix(vmop): set maintenance condition to false instead of early return

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

---------

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

Author: danilrwx

images/virtualization-artifact/pkg/controller/vmop/snapshot/internal/step/exit_maintenance_step.go

@@ -92,6 +92,8 @@ func (s ExitMaintenanceStep) Take(ctx context.Context, vmop *v1alpha2.VirtualMac
 			)
 			return &reconcile.Result{}, err
 		}
+
+		maintenanceVMCondition.Status = metav1.ConditionFalse
 	}
 
 	// If the maintenance condition was not present on the VM,

images/virtualization-artifact/pkg/controller/vmop/snapshot/internal/step/waiting_disk_ready_step.go

@@ -79,7 +79,7 @@ func (s WaitingDisksReadyStep) Take(ctx context.Context, vmop *v1alpha2.VirtualM
 			if k8serrors.IsNotFound(err) {
 				cb.Message("Waiting for resource readiness.")
 				conditions.SetCondition(cb, &vmop.Status.Conditions)
-				return nil, nil
+				return &reconcile.Result{}, nil
 			}
 			return &reconcile.Result{}, fmt.Errorf("failed to get the `VirtualDisk`: %w", err)
 		}