refactor(ci): polish Loop info logs and dedupe failedTests derivation

Follow-up to ba9ff18. Splits the loopRequest log message from the
error prefix so successful uploads log the file name again and the
post success log uses a readable verb instead of a lowercased acronym.
Extracts a module-private deriveFailedTestNames helper to remove the
duplicated Array.from(new Set(...map(test => test.name))) expression
in both Ginkgo parsers. JSON shape and markdown output unchanged.

Refs: virtualization2-mm4

Author: universal-itengineer

.github/scripts/js/e2e/report/messenger/loop-client.js

@@ -53,14 +53,14 @@ function parseLoopApiPayload(responseText, core) {
 }
 
 function createLoopClient({ loop, core, fetch: fetchFn = globalThis.fetch }) {
-  async function loopRequest(url, init, errorPrefix) {
+  async function loopRequest(url, init, { errorPrefix, successLog }) {
     const response = await fetchFn(url, init);
     const responseText = await response.text();
     if (!response.ok) {
       throw new Error(`${errorPrefix} failed with status ${response.status}: ${responseText}`);
     }
     const payload = parseLoopApiPayload(responseText, core);
-    core.info(`Loop API accepted ${errorPrefix.toLowerCase()} with status ${response.status}`);
+    core.info(`Loop API accepted ${successLog} with status ${response.status}`);
     return payload;
   }
 
@@ -81,7 +81,7 @@ function createLoopClient({ loop, core, fetch: fetchFn = globalThis.fetch }) {
         },
         body: JSON.stringify(body),
       },
-      "Loop API request"
+      { errorPrefix: "Loop API request", successLog: "post" }
     );
   }
 
@@ -98,7 +98,7 @@ function createLoopClient({ loop, core, fetch: fetchFn = globalThis.fetch }) {
         },
         body: formData,
       },
-      "Loop file upload"
+      { errorPrefix: "Loop file upload", successLog: `file ${name}` }
     );
     const fileId = payload.file_infos && payload.file_infos[0] && payload.file_infos[0].id;
     if (!fileId) {

.github/scripts/js/e2e/report/shared/ginkgo-report-utils.js

@@ -59,6 +59,18 @@ function flattenLabels(labelGroups) {
   return labels;
 }
 
+/**
+ * Derives a unique list of failed test names from the canonical
+ * `failedTestDetails` array. Kept module-private because the dedupe
+ * semantics are an internal detail of both Ginkgo parsers in this file.
+ *
+ * @param {Array<{name: string, reason: string}>} failedTestDetails Detailed failures.
+ * @returns {string[]} Unique failed test names preserving first occurrence order.
+ */
+function deriveFailedTestNames(failedTestDetails) {
+  return Array.from(new Set(failedTestDetails.map((test) => test.name)));
+}
+
 /**
  * Splits a raw Ginkgo SpecReport into stable, normalized parts used by
  * both the human-readable test name and per-spec timings.
@@ -231,7 +243,7 @@ function parseGinkgoReport(jsonContent) {
 
   return {
     metrics,
-    failedTests: Array.from(new Set(dedupedDetails.map((test) => test.name))),
+    failedTests: deriveFailedTestNames(dedupedDetails),
     failedTestDetails: dedupedDetails,
     specTimings,
     suiteTotalMs,
@@ -367,7 +379,7 @@ function parseGinkgoOutput(outputContent) {
   const failedTestDetails = [{ name, reason }];
   return {
     metrics: zeroMetrics(),
-    failedTests: Array.from(new Set(failedTestDetails.map((test) => test.name))),
+    failedTests: deriveFailedTestNames(failedTestDetails),
     failedTestDetails,
     specTimings: [],
     suiteTotalMs: 0,